From aed179f5f557664d6deb26ef6fdc6aa944af41af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Date: Wed, 1 Jun 2022 13:00:43 +0200 Subject: [PATCH] [lldb] [Process/FreeBSD] Do not send SIGSTOP to stopped process Do not send SIGSTOP when requested to halt a process that's already stopped. This results in the signal being queued for delivery once the process is resumed, and unexpectedly stopping it again. This is necessary for non-stop protocol patches to land. Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.llvm.org/D126770 --- lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp b/lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp index 21c9ead0eca4..5d73ec3457e3 100644 --- a/lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp +++ b/lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp @@ -497,6 +497,10 @@ Status NativeProcessFreeBSD::Resume(const ResumeActionList &resume_actions) { Status NativeProcessFreeBSD::Halt() { Status error; + // Do not try to stop a process that's already stopped, this may cause + // the SIGSTOP to get queued and stop the process again once resumed. + if (StateIsStoppedState(m_state, false)) + return error; if (kill(GetID(), SIGSTOP) != 0) error.SetErrorToErrno(); return error;