From ae611512549c1b66a7a05bfb9e55459955714715 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Tue, 2 Apr 2013 13:38:48 +0000 Subject: [PATCH] Escape # and $ in dependency files. Fixes PR15642. llvm-svn: 178540 --- clang/lib/Frontend/DependencyFile.cpp | 8 +++++--- clang/test/Frontend/dependency-gen-escaping.c | 17 +++++++++++++++++ 2 files changed, 22 insertions(+), 3 deletions(-) create mode 100644 clang/test/Frontend/dependency-gen-escaping.c diff --git a/clang/lib/Frontend/DependencyFile.cpp b/clang/lib/Frontend/DependencyFile.cpp index 53ea8befbc09..628def68e5e0 100644 --- a/clang/lib/Frontend/DependencyFile.cpp +++ b/clang/lib/Frontend/DependencyFile.cpp @@ -151,12 +151,14 @@ void DependencyFileCallback::AddFilename(StringRef Filename) { Files.push_back(Filename); } -/// PrintFilename - GCC escapes spaces, but apparently not ' or " or other -/// scary characters. +/// PrintFilename - GCC escapes spaces, # and $, but apparently not ' or " or +/// other scary characters. static void PrintFilename(raw_ostream &OS, StringRef Filename) { for (unsigned i = 0, e = Filename.size(); i != e; ++i) { - if (Filename[i] == ' ') + if (Filename[i] == ' ' || Filename[i] == '#') OS << '\\'; + else if (Filename[i] == '$') // $ is escaped by $$. + OS << '$'; OS << Filename[i]; } } diff --git a/clang/test/Frontend/dependency-gen-escaping.c b/clang/test/Frontend/dependency-gen-escaping.c new file mode 100644 index 000000000000..84eb242ec3c9 --- /dev/null +++ b/clang/test/Frontend/dependency-gen-escaping.c @@ -0,0 +1,17 @@ +// REQUIRES: shell +// PR15642 +// RUN: rm -rf %t.dir +// RUN: mkdir -p %t.dir +// RUN: echo > '%t.dir/ .h' +// RUN: echo > '%t.dir/$$.h' +// RUN: echo > '%t.dir/##.h' +// RUN: cd %t.dir +// RUN: %clang -MD -MF - %s -fsyntax-only -I. | FileCheck -strict-whitespace %s + +// CHECK: \ \ \ \ .h +// CHECK: $$$$.h +// CHECK: \#\#.h + +#include " .h" +#include "$$.h" +#include "##.h"