From ae1ab910cdce9f35670ab3ad44ae966fdd51ca31 Mon Sep 17 00:00:00 2001 From: Kamil Rytarowski Date: Sun, 23 Dec 2018 21:20:09 +0000 Subject: [PATCH] Tolerate flaky LLD tests on NetBSD Summary: For unknown reasons LLD tests are flaky on the NetBSD buildbot, but not on local machines of developers. Unless the linker will be fully functional on this target, allow to pass flaky tests with optional retry. Reviewers: joerg, mgorny, ruiu Reviewed By: mgorny Subscribers: lebedev.ri, MaskRay, llvm-commits, #lld Tags: #lld Differential Revision: https://reviews.llvm.org/D56053 llvm-svn: 350036 --- lld/test/lit.cfg.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lld/test/lit.cfg.py b/lld/test/lit.cfg.py index 9989a1cc97a2..7bc966c912fa 100644 --- a/lld/test/lit.cfg.py +++ b/lld/test/lit.cfg.py @@ -45,6 +45,11 @@ tool_patterns = [ llvm_config.add_tool_substitutions(tool_patterns) +# LLD tests tend to be flaky on NetBSD, so add some retries. +# We don't do this on other platforms because it's slower. +if platform.system() in ['NetBSD']: + config.test_retry_attempts = 2 + # When running under valgrind, we mangle '-vg' onto the end of the triple so we # can check it with XFAIL and XTARGET. if lit_config.useValgrind: