maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

NFC: Keep the dialect list in the context sorted by namespace. 

Most dialects are initialized statically, which does not have a guaranteed initialization order. By keeping the dialect list sorted, we can guarantee a deterministic iteration order of dialects.

PiperOrigin-RevId: 264522875
This commit is contained in:
River Riddle 2019-08-20 19:58:35 -07:00 committed by A. Unique TensorFlower
parent 5e17730cde
commit ad8b410f16
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
mlir/lib/IR/MLIRContext.cpp
View File

@ -333,18 +333,26 @@ Dialect *MLIRContext::getRegisteredDialect(StringRef name) {
/// takes ownership of the heap allocated dialect.
void Dialect::registerDialect(MLIRContext *context) {
auto &impl = context->getImpl();
std::unique_ptr<Dialect> dialect(this);
// Lock access to the context registry.
llvm::sys::SmartScopedWriter<true> registryLock(impl.contextMutex);
// Get the correct insertion position sorted by namespace.
auto insertPt =
llvm::lower_bound(impl.dialects, dialect,
[](const std::unique_ptr<Dialect> &lhs,
const std::unique_ptr<Dialect> &rhs) {
return lhs->getNamespace() < rhs->getNamespace();
});
// Abort if dialect with namespace has already been registered.
if (llvm::any_of(impl.dialects, [this](std::unique_ptr<Dialect> &dialect) {
return dialect->getNamespace() == getNamespace();
})) {
llvm::report_fatal_error("a dialect with namespace '" +
Twine(getNamespace()) +
if (insertPt != impl.dialects.end() &&
(*insertPt)->getNamespace() == getNamespace()) {
llvm::report_fatal_error("a dialect with namespace '" + getNamespace() +
"' has already been registered");
}
impl.dialects.push_back(std::unique_ptr<Dialect>(this));
impl.dialects.insert(insertPt, std::move(dialect));
}
/// Return information about all registered operations. This isn't very