From aad4027dc3b6e96fb949242a0635ef69151d6d70 Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Wed, 12 Sep 2018 18:10:22 +0000 Subject: [PATCH] Add compatibility version to liblldb in framework builds Summary: Building LLDB with xcodebuild sets the compatibility version of liblldb in LLDB.framework. Building the framework with cmake does not set the compatibility version, and so it defaults to 0.0.0. This is a discrepency in the difference between the xcode build and the cmake build. I tested this change by building without this patch. From the build tree I ran `otool -L Library/Frameworks/LLDB.framework/Versions/A/LLDB` and got this: ``` @rpath/LLDB.framework/Versions/A/LLDB (compatibility version 0.0.0, current version 8.0.0) ``` Did the same with this patch and the output contained this: ``` @rpath/LLDB.framework/Versions/A/LLDB (compatibility version 1.0.0, current version 8.0.0) ``` Reviewers: clayborg, labath Subscribers: mgorny, lldb-commits Differential Revision: https://reviews.llvm.org/D51959 llvm-svn: 342066 --- lldb/source/API/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/lldb/source/API/CMakeLists.txt b/lldb/source/API/CMakeLists.txt index fefab4bf84ff..3c5f4ddb43f6 100644 --- a/lldb/source/API/CMakeLists.txt +++ b/lldb/source/API/CMakeLists.txt @@ -146,6 +146,7 @@ endif() if (LLDB_BUILD_FRAMEWORK) set_target_properties(liblldb PROPERTIES + SOVERSION "1.0.0" OUTPUT_NAME LLDB FRAMEWORK On FRAMEWORK_VERSION ${LLDB_FRAMEWORK_VERSION}