maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[RegBankSelect] Reuse RegisterBankInfo logic to get to the register bank 

from a register.
On top of duplicating the logic, it was buggy! It would assert on
physical registers, since MachineRegisterInfo does not have any
information regarding register classes/banks for them.

llvm-svn: 265727
This commit is contained in:
Quentin Colombet 2016-04-07 21:32:23 +00:00
parent c53ad4f3b2
commit aac71a4a0e
2 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/include/llvm/CodeGen/GlobalISel/RegBankSelect.h
View File

@ -71,6 +71,7 @@
namespace llvm {
// Forward declarations.
class MachineRegisterInfo;
class TargetRegisterInfo;
/// This pass implements the reg bank selector pass used in the GlobalISel
/// pipeline. At the end of this pass, all register operands have been assigned
@ -87,6 +88,9 @@ private:
/// pass uses and updates.
MachineRegisterInfo *MRI;
/// Information on the register classes for the current function.
const TargetRegisterInfo *TRI;
/// Helper class used for every code morphing.
MachineIRBuilder MIRBuilder;

14
llvm/lib/CodeGen/GlobalISel/RegBankSelect.cpp
View File

@ -33,6 +33,7 @@ void RegBankSelect::init(MachineFunction &MF) {
RBI = MF.getSubtarget().getRegBankInfo();
assert(RBI && "Cannot work without RegisterBankInfo");
MRI = &MF.getRegInfo();
TRI = MF.getSubtarget().getRegisterInfo();
MIRBuilder.setMF(MF);
}
@ -43,18 +44,7 @@ bool RegBankSelect::assignmentMatch(
if (ValMapping.BreakDown.size() > 1)
return false;
const RegClassOrRegBank &CurAssignment = MRI->getRegClassOrRegBank(Reg);
// Nothing assigned, the assignment does not match.
if (!CurAssignment)
return false;
// Get the register bank form the current assignment.
const RegisterBank *CurRegBank = nullptr;
if (CurAssignment.is<const TargetRegisterClass *>())
CurRegBank = &RBI->getRegBankFromRegClass(
*CurAssignment.get<const TargetRegisterClass *>());
else
CurRegBank = CurAssignment.get<const RegisterBank *>();
return CurRegBank == ValMapping.BreakDown[0].RegBank;
return RBI->getRegBank(Reg, *MRI, *TRI) == ValMapping.BreakDown[0].RegBank;
}
unsigned