maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

reduce redundant calls of getMangledName. 

llvm-svn: 67440
This commit is contained in:
Chris Lattner 2009-03-21 08:06:59 +00:00
parent 3bfce1887f
commit a9cb6261bf
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
clang/lib/CodeGen/CodeGenModule.cpp
View File

@ -398,13 +398,13 @@ void CodeGenModule::EmitAliases() {
continue; continue;
} }
const char *MangledName = getMangledName(D);
llvm::GlobalValue *GA = llvm::GlobalValue *GA =
new llvm::GlobalAlias(aliasee->getType(), new llvm::GlobalAlias(aliasee->getType(),
llvm::Function::ExternalLinkage, llvm::Function::ExternalLinkage,
getMangledName(D), aliasee, MangledName, aliasee, &getModule());
&getModule());
llvm::GlobalValue *&Entry = GlobalDeclMap[getMangledName(D)]; llvm::GlobalValue *&Entry = GlobalDeclMap[MangledName];
if (Entry) { if (Entry) {
// If we created a dummy function for this then replace it. // If we created a dummy function for this then replace it.
GA->takeName(Entry); GA->takeName(Entry);
@ -597,7 +597,8 @@ void CodeGenModule::EmitGlobalDefinition(const ValueDecl *D) {
const llvm::Type *Ty = getTypes().ConvertTypeForMem(ASTTy); const llvm::Type *Ty = getTypes().ConvertTypeForMem(ASTTy);
// Lookup the entry, lazily creating it if necessary. // Lookup the entry, lazily creating it if necessary.
llvm::GlobalValue *&Entry = GlobalDeclMap[getMangledName(D)]; const char *MangledName = getMangledName(D);
llvm::GlobalValue *&Entry = GlobalDeclMap[MangledName];
if (Entry) { if (Entry) {
const llvm::Type *PTy = llvm::PointerType::get(Ty, ASTTy.getAddressSpace()); const llvm::Type *PTy = llvm::PointerType::get(Ty, ASTTy.getAddressSpace());
@ -610,7 +611,7 @@ void CodeGenModule::EmitGlobalDefinition(const ValueDecl *D) {
llvm::GlobalVariable *GV = llvm::GlobalVariable *GV =
new llvm::GlobalVariable(Ty, false, new llvm::GlobalVariable(Ty, false,
llvm::GlobalValue::ExternalLinkage, llvm::GlobalValue::ExternalLinkage,
0, getMangledName(D), &getModule(), 0, MangledName, &getModule(),
0, ASTTy.getAddressSpace()); 0, ASTTy.getAddressSpace());
// Handle things which are present even on external declarations. // Handle things which are present even on external declarations.
@ -665,13 +666,14 @@ void CodeGenModule::EmitGlobalVarDefinition(const VarDecl *D) {
} }
const llvm::Type* InitType = Init->getType(); const llvm::Type* InitType = Init->getType();
llvm::GlobalValue *&Entry = GlobalDeclMap[getMangledName(D)]; const char *MangledName = getMangledName(D);
llvm::GlobalValue *&Entry = GlobalDeclMap[MangledName];
llvm::GlobalVariable *GV = cast_or_null<llvm::GlobalVariable>(Entry); llvm::GlobalVariable *GV = cast_or_null<llvm::GlobalVariable>(Entry);
if (!GV) { if (!GV) {
GV = new llvm::GlobalVariable(InitType, false, GV = new llvm::GlobalVariable(InitType, false,
llvm::GlobalValue::ExternalLinkage, llvm::GlobalValue::ExternalLinkage,
0, getMangledName(D), 0, MangledName,
&getModule(), 0, ASTTy.getAddressSpace()); &getModule(), 0, ASTTy.getAddressSpace());
} else if (GV->hasInitializer() && !GV->getInitializer()->isNullValue()) { } else if (GV->hasInitializer() && !GV->getInitializer()->isNullValue()) {
@ -715,7 +717,7 @@ void CodeGenModule::EmitGlobalVarDefinition(const VarDecl *D) {
// Make a new global with the correct type // Make a new global with the correct type
GV = new llvm::GlobalVariable(InitType, false, GV = new llvm::GlobalVariable(InitType, false,
llvm::GlobalValue::ExternalLinkage, llvm::GlobalValue::ExternalLinkage,
0, getMangledName(D), 0, MangledName,
&getModule(), 0, ASTTy.getAddressSpace()); &getModule(), 0, ASTTy.getAddressSpace());
// Steal the name of the old global // Steal the name of the old global
GV->takeName(OldGV); GV->takeName(OldGV);