maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

LinalgOp::Model: add missing override specifiers 

All non-static functions in LinalgOp::Model override pure virtual functions
from LinalgOp::Concept, but only some of them have the `override` specifier.
This may lead one to erroneously believe the functions without the specified
are not overrides or virtual functions.  Add the specifier to all relevant
functions.

PiperOrigin-RevId: 256948453
This commit is contained in:
Alex Zinenko 2019-07-08 04:17:45 -07:00 committed by A. Unique TensorFlower
parent 7e74ee8ff7
commit a89b8aecca
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
mlir/include/mlir/Linalg/IR/LinalgOps.h
View File

@ -451,31 +451,33 @@ private:
unsigned getNumWindowLoops(Operation *op) override {
return cast<ConcreteOp>(op).getNumWindowLoops();
}
Value *getInput(Operation *op, unsigned i) {
Value *getInput(Operation *op, unsigned i) override {
return cast<ConcreteOp>(op).getInput(i);
}
llvm::Optional<unsigned> getIndexOfInput(Operation *op, Value *view) {
llvm::Optional<unsigned> getIndexOfInput(Operation *op,
Value *view) override {
return cast<ConcreteOp>(op).getIndexOfInput(view);
}
ViewType getInputViewType(Operation *op, unsigned i) {
ViewType getInputViewType(Operation *op, unsigned i) override {
return cast<ConcreteOp>(op).getInputViewType(i);
}
Operation::operand_range getInputs(Operation *op) {
Operation::operand_range getInputs(Operation *op) override {
return cast<ConcreteOp>(op).getInputs();
}
Value *getOutput(Operation *op, unsigned i) {
Value *getOutput(Operation *op, unsigned i) override {
return cast<ConcreteOp>(op).getOutput(i);
}
llvm::Optional<unsigned> getIndexOfOutput(Operation *op, Value *view) {
llvm::Optional<unsigned> getIndexOfOutput(Operation *op,
Value *view) override {
return cast<ConcreteOp>(op).getIndexOfOutput(view);
}
ViewType getOutputViewType(Operation *op, unsigned i) {
ViewType getOutputViewType(Operation *op, unsigned i) override {
return cast<ConcreteOp>(op).getOutputViewType(i);
}
Operation::operand_range getOutputs(Operation *op) {
Operation::operand_range getOutputs(Operation *op) override {
return cast<ConcreteOp>(op).getOutputs();
}
Operation::operand_range getInputsAndOutputs(Operation *op) {
Operation::operand_range getInputsAndOutputs(Operation *op) override {
return cast<ConcreteOp>(op).getInputsAndOutputs();
}
Operation *create(OpBuilder &builder, Location loc,