maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

R600: Fix a potential iterator invalidation issue. 

As a bonus this reduces the loop from O(n^2) to O(n).

llvm-svn: 183532
This commit is contained in:
Benjamin Kramer 2013-06-07 16:13:49 +00:00
parent 1edacecef4
commit a857fe115b
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
llvm/lib/Target/R600/R600OptimizeVectorRegisters.cpp
View File

@ -198,11 +198,9 @@ MachineInstr *R600VectorRegMerger::RebuildVector(
.addReg(SubReg)
.addImm(Chan);
UpdatedRegToChan[SubReg] = Chan;
for (std::vector<unsigned>::iterator RemoveIt = UpdatedUndef.begin(),
RemoveE = UpdatedUndef.end(); RemoveIt != RemoveE; ++ RemoveIt) {
if (*RemoveIt == Chan)
UpdatedUndef.erase(RemoveIt);
}
UpdatedUndef.erase(
std::remove(UpdatedUndef.begin(), UpdatedUndef.end(), Chan),
UpdatedUndef.end());
DEBUG(dbgs() << " ->"; Tmp->dump(););
(void)Tmp;
SrcVec = DstReg;