maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lld-link] Add comment explaining that /FIXED behavior is correct despite contradicting MSDN. 

Also add a test for /FIXED.
https://reviews.llvm.org/D45087

llvm-svn: 328879
This commit is contained in:
Nico Weber 2018-03-30 17:17:04 +00:00
parent d5cf5cf637
commit a764379458
2 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lld/COFF/Driver.cpp
View File

@ -962,6 +962,9 @@ void LinkerDriver::link(ArrayRef<const char *> ArgsArr) {
DynamicBaseArg->getOption().getID() == OPT_dynamicbase_no)
Config->DynamicBase = false;
// MSDN claims "/FIXED:NO is the default setting for a DLL, and /FIXED is the
// default setting for any other project type.", but link.exe defaults to
// /FIXED:NO for exe outputs as well. Match behavior, not docs.
bool Fixed = Args.hasFlag(OPT_fixed, OPT_fixed_no, false);
if (Fixed) {
if (DynamicBaseArg &&

24
lld/test/COFF/fixed.test Normal file
View File

@ -0,0 +1,24 @@
# REQUIRES: x86
# RUN: yaml2obj < %p/Inputs/hello32.yaml > %t.obj
#
# RUN: lld-link %t.obj /fixed %p/Inputs/std32.lib /subsystem:console \
# RUN: /entry:main@0 /debug /out:%t.fixed.exe
# RUN: llvm-readobj -file-headers %t.fixed.exe | \
# RUN: FileCheck -check-prefix=EXEFIXED %s
#
# RUN: lld-link %t.obj %p/Inputs/std32.lib /subsystem:console \
# RUN: /entry:main@0 /debug /out:%t.exe
# RUN: llvm-readobj -file-headers %t.exe | FileCheck -check-prefix=EXEREL %s
#
# RUN: yaml2obj < %p/Inputs/export.yaml > %t.obj
#
# RUN: lld-link %t.obj /dll /fixed /debug /out:%t.fixed.dll
# RUN: llvm-readobj -file-headers %t.fixed.dll | FileCheck -check-prefix=DLLFIXED %s
#
# RUN: lld-link %t.obj /dll /debug /out:%t.dll
# RUN: llvm-readobj -file-headers %t.dll | FileCheck -check-prefix=DLLREL %s
EXEFIXED-NOT: IMAGE_DLL_CHARACTERISTICS_DYNAMIC_BASE
DLLFIXED-NOT: IMAGE_DLL_CHARACTERISTICS_DYNAMIC_BASE
EXEREL: IMAGE_DLL_CHARACTERISTICS_DYNAMIC_BASE
DLLREL: IMAGE_DLL_CHARACTERISTICS_DYNAMIC_BASE