From a6fdfaa595ec41ed4800d447b8669c69fb696ba8 Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Thu, 18 Oct 2012 20:54:37 +0000 Subject: [PATCH] Fix AST pretty-printing for C++ new expressions with placement arguments with default values. Based on patch by Grzegorz Jablonski. llvm-svn: 166226 --- clang/lib/AST/StmtPrinter.cpp | 4 +++- clang/test/SemaCXX/ast-print.cpp | 11 +++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/clang/lib/AST/StmtPrinter.cpp b/clang/lib/AST/StmtPrinter.cpp index 892442ea3bff..d7392af808ea 100644 --- a/clang/lib/AST/StmtPrinter.cpp +++ b/clang/lib/AST/StmtPrinter.cpp @@ -1415,10 +1415,12 @@ void StmtPrinter::VisitCXXNewExpr(CXXNewExpr *E) { OS << "::"; OS << "new "; unsigned NumPlace = E->getNumPlacementArgs(); - if (NumPlace > 0) { + if (NumPlace > 0 && !isa(E->getPlacementArg(0))) { OS << "("; PrintExpr(E->getPlacementArg(0)); for (unsigned i = 1; i < NumPlace; ++i) { + if (isa(E->getPlacementArg(i))) + break; OS << ", "; PrintExpr(E->getPlacementArg(i)); } diff --git a/clang/test/SemaCXX/ast-print.cpp b/clang/test/SemaCXX/ast-print.cpp index 44b34aa12cfa..46b99e0d6100 100644 --- a/clang/test/SemaCXX/ast-print.cpp +++ b/clang/test/SemaCXX/ast-print.cpp @@ -30,3 +30,14 @@ void f() switch (int a = 1) { } } +// CHECK: new (1) int; +void *operator new (typeof(sizeof(1)), int, int = 2); +void f2() { + new (1) int; +} + +// CHECK: new X; +struct X { + void *operator new (typeof(sizeof(1)), int = 2); +}; +void f2() { new X; }