From a6e047a5d9db630743597c611ebd8997681808b1 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Mon, 6 May 2002 18:54:59 +0000 Subject: [PATCH] Only do masking for unsigned values! llvm-svn: 2504 --- .../Transforms/Scalar/InstructionCombining.cpp | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/llvm/lib/Transforms/Scalar/InstructionCombining.cpp b/llvm/lib/Transforms/Scalar/InstructionCombining.cpp index 5b9f31892ea2..fda64ab49adf 100644 --- a/llvm/lib/Transforms/Scalar/InstructionCombining.cpp +++ b/llvm/lib/Transforms/Scalar/InstructionCombining.cpp @@ -249,16 +249,15 @@ static Constant *getMaxValue(const Type *Ty) { if (Ty == Type::BoolTy) return ConstantBool::True; - // Calculate -1 casted to the right type... - unsigned TypeBits = Ty->getPrimitiveSize()*8; - uint64_t Val = (uint64_t)-1LL; // All ones - Val >>= 64-TypeBits; // Shift out unwanted 1 bits... - if (Ty->isSigned()) - return ConstantSInt::get(Ty, (int64_t)Val); - else if (Ty->isUnsigned()) + return ConstantSInt::get(Ty, -1); + else if (Ty->isUnsigned()) { + // Calculate -1 casted to the right type... + unsigned TypeBits = Ty->getPrimitiveSize()*8; + uint64_t Val = (uint64_t)-1LL; // All ones + Val >>= 64-TypeBits; // Shift out unwanted 1 bits... return ConstantUInt::get(Ty, Val); - + } return 0; }