Use separate named MDNode to hold each function's local variable info.

This speeds up local variable handling in DwarfDebug.

llvm-svn: 106075
This commit is contained in:
Devang Patel 2010-06-16 00:53:55 +00:00
parent 6972a62c8f
commit a6d20f446f
4 changed files with 17 additions and 4 deletions

View File

@ -326,6 +326,7 @@ public:
/// specified name. This method returns null if a NamedMDNode with the
/// specified name is not found.
NamedMDNode *getNamedMetadata(StringRef Name) const;
NamedMDNode *getNamedMetadataUsingTwine(Twine Name) const;
/// getOrInsertNamedMetadata - Return the first named MDNode in the module
/// with the specified name. This method returns a new NamedMDNode if a

View File

@ -1053,8 +1053,12 @@ DIVariable DIFactory::CreateVariable(unsigned Tag, DIDescriptor Context,
// The optimizer may remove local variable. If there is an interest
// to preserve variable info in such situation then stash it in a
// named mdnode.
NamedMDNode *NMD = M.getOrInsertNamedMetadata("llvm.dbg.lv");
NMD->addOperand(Node);
DISubprogram Fn(getDISubprogram(Context));
const Twine FnLVName = Twine("llvm.dbg.lv.", Fn.getName());
NamedMDNode *FnLocals = M.getNamedMetadataUsingTwine(FnLVName);
if (!FnLocals)
FnLocals = NamedMDNode::Create(VMContext, FnLVName, NULL, 0, &M);
FnLocals->addOperand(Node);
}
return DIVariable(Node);
}

View File

@ -2259,8 +2259,9 @@ void DwarfDebug::collectVariableInfo(const MachineFunction *MF) {
}
// Collect info for variables that were optimized out.
const Twine FnLVName = Twine("llvm.dbg.lv.", MF->getFunction()->getName());
if (NamedMDNode *NMD =
MF->getFunction()->getParent()->getNamedMetadata("llvm.dbg.lv")) {
MF->getFunction()->getParent()->getNamedMetadataUsingTwine(FnLVName)) {
for (unsigned i = 0, e = NMD->getNumOperands(); i != e; ++i) {
DIVariable DV(cast_or_null<MDNode>(NMD->getOperand(i)));
if (!DV || !Processed.insert(DV))

View File

@ -17,6 +17,7 @@
#include "llvm/DerivedTypes.h"
#include "llvm/GVMaterializer.h"
#include "llvm/LLVMContext.h"
#include "llvm/ADT/SmallString.h"
#include "llvm/ADT/STLExtras.h"
#include "llvm/ADT/StringExtras.h"
#include "llvm/Support/LeakDetector.h"
@ -316,6 +317,12 @@ NamedMDNode *Module::getNamedMetadata(StringRef Name) const {
return NamedMDSymTab->lookup(Name);
}
NamedMDNode *Module::getNamedMetadataUsingTwine(Twine Name) const {
SmallString<256> NameData;
StringRef NameRef = Name.toStringRef(NameData);
return NamedMDSymTab->lookup(NameRef);
}
/// getOrInsertNamedMetadata - Return the first named MDNode in the module
/// with the specified name. This method returns a new NamedMDNode if a
/// NamedMDNode with the specified name is not found.