maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Warn about visibility attributes in typedefs. 

llvm-svn: 156534
This commit is contained in:
Rafael Espindola 2012-05-10 03:01:34 +00:00
parent 5cc6ef9e89
commit a6b3cd493c
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clang/lib/Sema/SemaDeclAttr.cpp
View File

@ -1857,6 +1857,10 @@ static void handleAvailabilityAttr(Sema &S, Decl *D,
bool Sema::mergeVisibilityAttr(Decl *D, SourceRange Range,
bool Inherited,
VisibilityAttr::VisibilityType Vis) {
if (isa<TypedefNameDecl>(D)) {
Diag(Range.getBegin(), diag::warn_attribute_ignored) << "visibility";
return false;
}
VisibilityAttr *ExistingAttr = D->getAttr<VisibilityAttr>();
if (ExistingAttr) {
VisibilityAttr::VisibilityType ExistingVis = ExistingAttr->getVisibility();

2
clang/test/Sema/attr-visibility.c
View File

@ -20,3 +20,5 @@ void test6() __attribute__((visibility("hidden"), // expected-note {{previous at
extern int test7 __attribute__((visibility("default"))); // expected-note {{previous attribute is here}}
extern int test7 __attribute__((visibility("hidden"))); // expected-error {{visibility does not match previous declaration}}
typedef int __attribute__((visibility("default"))) bar; // expected-warning {{visibility attribute ignored}}