maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Replace spurious SmallVector constructions with ValueRange 

Signed-off-by: Uday Bondhugula <uday@polymagelabs.com>

Closes tensorflow/mlir#305

COPYBARA_INTEGRATE_REVIEW=https://github.com/tensorflow/mlir/pull/305 from bondhugula:value_range 21d1fae73f549e3c8e72b60876eff1b864cea39c
PiperOrigin-RevId: 284541027
This commit is contained in:
Uday Bondhugula 2019-12-09 06:26:05 -08:00 committed by A. Unique TensorFlower
parent ade58a268c
commit a63f6e0bf9
6 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h
View File

@ -75,8 +75,8 @@ public:
/// and use pointers to struct to avoid the complexity of the
/// platform-specific C/C++ ABI lowering related to struct argument passing.
SmallVector<Value *, 4> promoteMemRefDescriptors(Location loc,
ArrayRef<Value *> opOperands,
ArrayRef<Value *> operands,
ValueRange opOperands,
ValueRange operands,
OpBuilder &builder);
/// Promote the LLVM struct representation of one MemRef descriptor to stack

2
mlir/include/mlir/IR/OperationSupport.h
View File

@ -274,7 +274,7 @@ public:
OperationState(Location location, OperationName name);
OperationState(Location location, StringRef name, ArrayRef<Value *> operands,
OperationState(Location location, StringRef name, ValueRange operands,
ArrayRef<Type> types, ArrayRef<NamedAttribute> attributes,
ArrayRef<Block *> successors = {},
MutableArrayRef<std::unique_ptr<Region>> regions = {},

5
mlir/lib/Analysis/AffineStructures.cpp
View File

@ -659,9 +659,8 @@ LogicalResult FlatAffineConstraints::composeMap(const AffineValueMap *vMap) {
// Add localCst information.
if (localCst.getNumLocalIds() > 0) {
SmallVector<Value *, 8> values(vMap->getOperands().begin(),
vMap->getOperands().end());
localCst.setIdValues(0, localCst.getNumDimAndSymbolIds(), values);
localCst.setIdValues(0, /*end=*/localCst.getNumDimAndSymbolIds(),
/*values=*/vMap->getOperands());
// Align localCst and this.
mergeAndAlignIds(/*offset=*/0, &localCst, this);
// Finally, append localCst to this constraint set.

10
mlir/lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp
View File

@ -1110,9 +1110,8 @@ struct CallOpInterfaceLowering : public LLVMLegalizationPattern<CallOpType> {
return this->matchFailure();
}
SmallVector<Value *, 4> opOperands(op->getOperands());
auto promoted = this->lowering.promoteMemRefDescriptors(
op->getLoc(), opOperands, operands, rewriter);
op->getLoc(), /*opOperands=*/op->getOperands(), operands, rewriter);
auto newOp = rewriter.create<LLVM::CallOp>(op->getLoc(), packedResult,
promoted, op->getAttrs());
@ -2078,9 +2077,10 @@ Value *LLVMTypeConverter::promoteOneMemRefDescriptor(Location loc,
return allocated;
}
SmallVector<Value *, 4> LLVMTypeConverter::promoteMemRefDescriptors(
Location loc, ArrayRef<Value *> opOperands, ArrayRef<Value *> operands,
OpBuilder &builder) {
SmallVector<Value *, 4>
LLVMTypeConverter::promoteMemRefDescriptors(Location loc, ValueRange opOperands,
ValueRange operands,
OpBuilder &builder) {
SmallVector<Value *, 4> promotedOperands;
promotedOperands.reserve(operands.size());
for (auto it : llvm::zip(opOperands, operands)) {

2
mlir/lib/IR/OperationSupport.cpp
View File

@ -36,7 +36,7 @@ OperationState::OperationState(Location location, OperationName name)
: location(location), name(name) {}
OperationState::OperationState(Location location, StringRef name,
ArrayRef<Value *> operands, ArrayRef<Type> types,
ValueRange operands, ArrayRef<Type> types,
ArrayRef<NamedAttribute> attributes,
ArrayRef<Block *> successors,
MutableArrayRef<std::unique_ptr<Region>> regions,

3
mlir/lib/Transforms/Utils/LoopUtils.cpp
View File

@ -1235,11 +1235,10 @@ static AffineForOp generatePointWiseCopy(Location loc, Value *memref,
memIndicesStart);
// Construct the subscript for the slow memref being copied.
SmallVector<Value *, 2> operands = {memBase, forOp.getInductionVar()};
auto memIndex = b.create<AffineApplyOp>(
loc,
AffineMap::get(2, 0, b.getAffineDimExpr(0) + b.getAffineDimExpr(1)),
operands);
ValueRange({memBase, forOp.getInductionVar()}));
memIndices.push_back(memIndex);
}