maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

MachineInstr: Remove parameter from dump() 

The primary use of the dump() functions in LLVM is for use in a
debugger. Unfortunately lldb does not seem to handle default arguments
so using `p SomeMI.dump()` fails and you have to type the longer `p
SomeMI.dump(nullptr)`. Remove the paramter to make the most common use
easy. (You can always construct something like `p
SomeMI.print(dbgs(),MyTII)` if you need more features).

Differential Revision: https://reviews.llvm.org/D29241

llvm-svn: 293440
This commit is contained in:
Matthias Braun 2017-01-29 18:20:42 +00:00
parent 87996f906a
commit a4976c6166
3 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/include/llvm/CodeGen/MachineInstr.h
View File

@ -1153,7 +1153,7 @@ public:
const TargetInstrInfo *TII = nullptr) const; const TargetInstrInfo *TII = nullptr) const;
void print(raw_ostream &OS, ModuleSlotTracker &MST, bool SkipOpers = false, void print(raw_ostream &OS, ModuleSlotTracker &MST, bool SkipOpers = false,
const TargetInstrInfo *TII = nullptr) const; const TargetInstrInfo *TII = nullptr) const;
void dump(const TargetInstrInfo *TII = nullptr) const; void dump() const;
//===--------------------------------------------------------------------===// //===--------------------------------------------------------------------===//
// Accessors used to build up machine instructions. // Accessors used to build up machine instructions.

4
llvm/lib/CodeGen/MachineCombiner.cpp
View File

@ -135,7 +135,9 @@ MachineCombiner::getDepth(SmallVectorImpl<MachineInstr *> &InsInstrs,
// are tracked in the InstrIdxForVirtReg map depth is looked up in InstrDepth // are tracked in the InstrIdxForVirtReg map depth is looked up in InstrDepth
for (auto *InstrPtr : InsInstrs) { // for each Use for (auto *InstrPtr : InsInstrs) { // for each Use
unsigned IDepth = 0; unsigned IDepth = 0;
DEBUG(dbgs() << "NEW INSTR "; InstrPtr->dump(TII); dbgs() << "\n";); DEBUG(dbgs() << "NEW INSTR ";
InstrPtr->print(dbgs(), TII);
dbgs() << "\n";);
for (const MachineOperand &MO : InstrPtr->operands()) { for (const MachineOperand &MO : InstrPtr->operands()) {
// Check for virtual register operand. // Check for virtual register operand.
if (!(MO.isReg() && TargetRegisterInfo::isVirtualRegister(MO.getReg()))) if (!(MO.isReg() && TargetRegisterInfo::isVirtualRegister(MO.getReg())))

4
llvm/lib/CodeGen/MachineInstr.cpp
View File

@ -1693,9 +1693,9 @@ void MachineInstr::copyImplicitOps(MachineFunction &MF,
} }
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
LLVM_DUMP_METHOD void MachineInstr::dump(const TargetInstrInfo *TII) const { LLVM_DUMP_METHOD void MachineInstr::dump() const {
dbgs() << " "; dbgs() << " ";
print(dbgs(), false /* SkipOpers */, TII); print(dbgs());
} }
#endif #endif