diff --git a/clang/lib/AST/Decl.cpp b/clang/lib/AST/Decl.cpp index a36fcf2507b2..c799161e9b77 100644 --- a/clang/lib/AST/Decl.cpp +++ b/clang/lib/AST/Decl.cpp @@ -1043,9 +1043,13 @@ static LinkageInfo getLVForLocalDecl(const NamedDecl *D, return LV; } + + if (!Var->isStaticLocal()) + return LinkageInfo::none(); } - if (!isa(D)) + ASTContext &Context = D->getASTContext(); + if (!Context.getLangOpts().CPlusPlus) return LinkageInfo::none(); const FunctionDecl *FD = getOutermostFunctionContext(D); diff --git a/clang/lib/CodeGen/CGDecl.cpp b/clang/lib/CodeGen/CGDecl.cpp index cb1574864631..614eaab3f373 100644 --- a/clang/lib/CodeGen/CGDecl.cpp +++ b/clang/lib/CodeGen/CGDecl.cpp @@ -126,10 +126,8 @@ void CodeGenFunction::EmitVarDecl(const VarDecl &D) { // If the function definition has some sort of weak linkage, its // static variables should also be weak so that they get properly - // uniqued. We can't do this in C, though, because there's no - // standard way to agree on which variables are the same (i.e. - // there's no mangling). - if (getLangOpts().CPlusPlus) { + // uniqued. + if (D.isExternallyVisible()) { const Decl *D = CurCodeDecl; while (true) { if (isa(D)) { @@ -143,7 +141,7 @@ void CodeGenFunction::EmitVarDecl(const VarDecl &D) { } } // FIXME: Do we really only care about FunctionDecls here? - if (D && isa(D)) { + if (isa(D)) { llvm::GlobalValue::LinkageTypes ParentLinkage = CGM.getFunctionLinkage(cast(D)); if (llvm::GlobalValue::isWeakForLinker(ParentLinkage)) diff --git a/clang/test/CodeGenCXX/linkage.cpp b/clang/test/CodeGenCXX/linkage.cpp index 7c670293996b..c7feaefeb85d 100644 --- a/clang/test/CodeGenCXX/linkage.cpp +++ b/clang/test/CodeGenCXX/linkage.cpp @@ -209,3 +209,14 @@ namespace test16 { } void *test() { return foo::bar(); } } + +namespace test17 { + // CHECK-DAG: @_ZZN6test173fooILi42EEEPivE3bar = weak_odr + // CHECK-DAG: define weak_odr i32* @_ZN6test173fooILi42EEEPiv( + template + int *foo() { + static int bar; + return &bar; + } + template int *foo<42>(); +}