maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Analysis: Make %I in printf more reasonable, add more tests 

llvm-svn: 188992
This commit is contained in:
David Majnemer 2013-08-22 07:53:21 +00:00
parent a31a882f87
commit a39da8e236
2 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
clang/lib/Analysis/PrintfFormatString.cpp
View File

@ -296,8 +296,9 @@ ArgType PrintfSpecifier::getArgType(ASTContext &Ctx,
// FIXME: How to get the corresponding signed version of size_t?
return ArgType();
case LengthModifier::AsInt3264:
return Ctx.getTargetInfo().getTriple().isArch64Bit() ? Ctx.LongLongTy
: Ctx.IntTy;
return Ctx.getTargetInfo().getTriple().isArch64Bit()
? ArgType(Ctx.LongLongTy, "__int64")
: ArgType(Ctx.IntTy, "__int32");
case LengthModifier::AsPtrDiff:
return ArgType(Ctx.getPointerDiffType(), "ptrdiff_t");
case LengthModifier::AsAllocate:
@ -328,8 +329,8 @@ ArgType PrintfSpecifier::getArgType(ASTContext &Ctx,
return ArgType(Ctx.getSizeType(), "size_t");
case LengthModifier::AsInt3264:
return Ctx.getTargetInfo().getTriple().isArch64Bit()
? Ctx.UnsignedLongLongTy
: Ctx.UnsignedIntTy;
? ArgType(Ctx.UnsignedLongLongTy, "unsigned __int64")
: ArgType(Ctx.UnsignedIntTy, "unsigned __int32");
case LengthModifier::AsPtrDiff:
// FIXME: How to get the corresponding unsigned
// version of ptrdiff_t?

18
clang/test/Sema/format-strings-ms.c
View File

@ -2,8 +2,24 @@
int printf(const char *format, ...) __attribute__((format(printf, 1, 2)));
void test() {
void unsigned_test() {
short val = 30;
printf("val = %I64d\n", val); // expected-warning{{'I64' length modifier is not supported by ISO C}} \
// expected-warning{{format specifies type '__int64' (aka 'long long') but the argument has type 'short'}}
long long bigval = 30;
printf("val = %I32d\n", bigval); // expected-warning{{'I32' length modifier is not supported by ISO C}} \
// expected-warning{{format specifies type '__int32' (aka 'int') but the argument has type 'long long'}}
printf("val = %Id\n", bigval); // expected-warning{{'I' length modifier is not supported by ISO C}} \
// expected-warning{{format specifies type '__int32' (aka 'int') but the argument has type 'long long'}}
}
void signed_test() {
unsigned short val = 30;
printf("val = %I64u\n", val); // expected-warning{{'I64' length modifier is not supported by ISO C}} \
// expected-warning{{format specifies type 'unsigned __int64' (aka 'unsigned long long') but the argument has type 'unsigned short'}}
unsigned long long bigval = 30;
printf("val = %I32u\n", bigval); // expected-warning{{'I32' length modifier is not supported by ISO C}} \
// expected-warning{{format specifies type 'unsigned __int32' (aka 'unsigned int') but the argument has type 'unsigned long long'}}
printf("val = %Iu\n", bigval); // expected-warning{{'I' length modifier is not supported by ISO C}} \
// expected-warning{{format specifies type 'unsigned __int32' (aka 'unsigned int') but the argument has type 'unsigned long long'}}
}