maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lld][WebAssembly] Feedback from D92038. NFC 

Differential Revision: https://reviews.llvm.org/D92429
This commit is contained in:
Sam Clegg 2020-12-01 14:04:21 -08:00
parent d67e58f23a
commit a38ed62ea8
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lld/test/wasm/weak-undefined-pic.s
View File

@ -27,7 +27,7 @@ _start:
.weak foo .weak foo
.functype foo () -> (i32) .functype foo () -> (i32)
# Verify that we do not generate dynamnic relocations for the GOT entry. # Verify that we do not generate dynamic relocations for the GOT entry.
# CHECK-NOT: __wasm_apply_relocs # CHECK-NOT: __wasm_apply_relocs
@ -68,7 +68,7 @@ _start:
# CHECK-NEXT: - Index: 1 # CHECK-NEXT: - Index: 1
# CHECK-NEXT: Name: 'undefined_weak:foo' # CHECK-NEXT: Name: 'undefined_weak:foo'
# With `-pie` or `-shared` the resolution should is defered to the dynamic # With `-pie` or `-shared` the resolution should be deferred to the dynamic
# linker and the function address should be imported as GOT.func.foo. # linker and the function address should be imported as GOT.func.foo.
# #
# RUN: wasm-ld --experimental-pic -pie %t.o -o %t3.wasm # RUN: wasm-ld --experimental-pic -pie %t.o -o %t3.wasm

3
lld/wasm/Symbols.h
View File

@ -160,6 +160,9 @@ public:
// True if this symbol is a linker-synthesized stub function (traps when // True if this symbol is a linker-synthesized stub function (traps when
// called) and should otherwise be treated as missing/undefined. See // called) and should otherwise be treated as missing/undefined. See
// SymbolTable::replaceWithUndefined. // SymbolTable::replaceWithUndefined.
// These stubs never appear in the table and any table index relocations
// against them will produce address 0 (The table index representing
// the null function pointer).
bool isStub : 1; bool isStub : 1;
uint32_t flags; uint32_t flags;