maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[libc++] Fix reverse_iterator test when UBSan is enabled 

The goal of the test was only to check that we could access the
`this->current` member of std::reverse_iterator from a derived
class, but in doing so we incremented a null iterator, which is UB.
This commit is contained in:
Louis Dionne 2020-03-04 11:32:49 -05:00
parent 71a316883d
commit a2fe17cdc6
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libcxx/test/std/iterators/predef.iterators/reverse.iterators/reverse.iterator/types.pass.cpp
View File

@ -34,7 +34,7 @@ template <class It>
struct find_current
: private std::reverse_iterator<It>
{
void test() {++(this->current);}
void test() { (void)this->current; }
};
template <class It>
@ -43,8 +43,7 @@ test()
{
typedef std::reverse_iterator<It> R;
typedef std::iterator_traits<It> T;
find_current<It> q;
q.test();
find_current<It> q; q.test(); // Just test that we can access `.current` from derived classes
static_assert((std::is_same<typename R::iterator_type, It>::value), "");
static_assert((std::is_same<typename R::value_type, typename T::value_type>::value), "");
static_assert((std::is_same<typename R::difference_type, typename T::difference_type>::value), "");
@ -59,5 +58,5 @@ int main(int, char**)
test<random_access_iterator<char*> >();
test<char*>();
return 0;
return 0;
}