forked from OSchip/llvm-project
[lldb] Use is_style_posix() for path style checks
Sincea8b54834a1
, there are two distinct Windows path styles, `windows_backslash` (with the old `windows` being an alias for it) and `windows_slash`.4e4883e1f3
added helpers for inspecting path styles. The newly added windows_slash path style doesn't end up used in LLDB yet anyway, as LLDB is quite decoupled from most of llvm::sys::path and uses its own FileSpec class. To take it in use, it could be hooked up in `FileSpec::Style::GetNativeStyle` (in lldb/source/Utility/FileSpec.cpp) just like in the `real_style` function in llvm/lib/Support/Path.cpp indf0ba47c36
. It is not currently clear whether there's a real need for using the Windows path style with forward slashes in LLDB (if there's any other applications interacting with it, expecting that style), and what other changes in LLDB are needed for that to work, but this at least makes some of the checks more ready for the new style, simplifying code a bit. Differential Revision: https://reviews.llvm.org/D113255
This commit is contained in:
parent
f0955922a2
commit
a2c9cf4c76
|
@ -202,7 +202,7 @@ public:
|
|||
/// \return
|
||||
/// \b true if the file path is case sensitive (POSIX), false
|
||||
/// if case insensitive (Windows).
|
||||
bool IsCaseSensitive() const { return m_style != Style::windows; }
|
||||
bool IsCaseSensitive() const { return is_style_posix(m_style); }
|
||||
|
||||
/// Dump this object to a Stream.
|
||||
///
|
||||
|
|
|
@ -43,9 +43,7 @@ static constexpr FileSpec::Style GetNativeStyle() {
|
|||
}
|
||||
|
||||
bool PathStyleIsPosix(FileSpec::Style style) {
|
||||
return (style == FileSpec::Style::posix ||
|
||||
(style == FileSpec::Style::native &&
|
||||
GetNativeStyle() == FileSpec::Style::posix));
|
||||
return llvm::sys::path::is_style_posix(style);
|
||||
}
|
||||
|
||||
const char *GetPathSeparators(FileSpec::Style style) {
|
||||
|
|
Loading…
Reference in New Issue