Remove getSymbolValue.

All existing users explicitly ask for an address or a file offset.

llvm-svn: 205503
This commit is contained in:
Rafael Espindola 2014-04-03 02:32:47 +00:00
parent 41de905e25
commit a2782f6e77
6 changed files with 0 additions and 29 deletions

View File

@ -371,7 +371,6 @@ protected:
SymbolRef::Type &Res) const override;
error_code getSymbolSection(DataRefImpl Symb,
section_iterator &Res) const override;
error_code getSymbolValue(DataRefImpl Symb, uint64_t &Val) const override;
void moveSectionNext(DataRefImpl &Sec) const override;
error_code getSectionName(DataRefImpl Sec, StringRef &Res) const override;
error_code getSectionAddress(DataRefImpl Sec, uint64_t &Res) const override;

View File

@ -68,7 +68,6 @@ protected:
SymbolRef::Type &Res) const override;
error_code getSymbolSection(DataRefImpl Symb,
section_iterator &Res) const override;
error_code getSymbolValue(DataRefImpl Symb, uint64_t &Val) const override;
error_code getLibraryNext(DataRefImpl Data,
LibraryRef &Result) const override;
@ -395,14 +394,6 @@ error_code ELFObjectFile<ELFT>::getSymbolSection(DataRefImpl Symb,
return object_error::success;
}
template <class ELFT>
error_code ELFObjectFile<ELFT>::getSymbolValue(DataRefImpl Symb,
uint64_t &Val) const {
const Elf_Sym *ESym = getSymbol(Symb);
Val = ESym->st_value;
return object_error::success;
}
template <class ELFT>
void ELFObjectFile<ELFT>::moveSectionNext(DataRefImpl &Sec) const {
Sec = toDRI(++toELFShdrIter(Sec));

View File

@ -71,7 +71,6 @@ public:
uint32_t getSymbolFlags(DataRefImpl Symb) const override;
error_code getSymbolSection(DataRefImpl Symb,
section_iterator &Res) const override;
error_code getSymbolValue(DataRefImpl Symb, uint64_t &Val) const override;
void moveSectionNext(DataRefImpl &Sec) const override;
error_code getSectionName(DataRefImpl Sec, StringRef &Res) const override;

View File

@ -156,9 +156,6 @@ public:
/// end_sections() if it is undefined or is an absolute symbol.
error_code getSection(section_iterator &Result) const;
/// @brief Get value of the symbol in the symbol table.
error_code getValue(uint64_t &Val) const;
const ObjectFile *getObject() const;
};
@ -238,7 +235,6 @@ protected:
SymbolRef::Type &Res) const = 0;
virtual error_code getSymbolSection(DataRefImpl Symb,
section_iterator &Res) const = 0;
virtual error_code getSymbolValue(DataRefImpl Symb, uint64_t &Val) const = 0;
// Same as above for SectionRef.
friend class SectionRef;
@ -375,10 +371,6 @@ inline error_code SymbolRef::getType(SymbolRef::Type &Result) const {
return getObject()->getSymbolType(getRawDataRefImpl(), Result);
}
inline error_code SymbolRef::getValue(uint64_t &Val) const {
return getObject()->getSymbolValue(getRawDataRefImpl(), Val);
}
inline const ObjectFile *SymbolRef::getObject() const {
const SymbolicFile *O = BasicSymbolRef::getObject();
return cast<ObjectFile>(O);

View File

@ -252,11 +252,6 @@ error_code COFFObjectFile::getSymbolSection(DataRefImpl Ref,
return object_error::success;
}
error_code COFFObjectFile::getSymbolValue(DataRefImpl Ref,
uint64_t &Val) const {
report_fatal_error("getSymbolValue unimplemented in COFFObjectFile");
}
void COFFObjectFile::moveSectionNext(DataRefImpl &Ref) const {
const coff_section *Sec = toSec(Ref);
Sec += 1;

View File

@ -631,11 +631,6 @@ MachOObjectFile::getSymbolSection(DataRefImpl Symb,
return object_error::success;
}
error_code MachOObjectFile::getSymbolValue(DataRefImpl Symb,
uint64_t &Val) const {
report_fatal_error("getSymbolValue unimplemented in MachOObjectFile");
}
void MachOObjectFile::moveSectionNext(DataRefImpl &Sec) const {
Sec.d.a++;
}