maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Pass the VLA size expr range to the VLA diags 

llvm-svn: 60645
This commit is contained in:
Anders Carlsson 2008-12-07 00:49:48 +00:00
parent ccb9c3370a
commit a1a9c28d30
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
clang/lib/Sema/SemaDecl.cpp
View File

@ -1928,17 +1928,27 @@ Sema::DeclTy *Sema::FinalizeDeclaratorGroup(Scope *S, DeclTy *group) {
QualType T = IDecl->getType(); QualType T = IDecl->getType();
if (T->isVariableArrayType()) { if (T->isVariableArrayType()) {
const VariableArrayType *VAT =
cast<VariableArrayType>(T.getUnqualifiedType());
// FIXME: This won't give the correct result for
// int a[10][n];
SourceRange SizeRange = VAT->getSizeExpr()->getSourceRange();
if (IDecl->isFileVarDecl()) { if (IDecl->isFileVarDecl()) {
Diag(IDecl->getLocation(), diag::err_vla_decl_in_file_scope); Diag(IDecl->getLocation(), diag::err_vla_decl_in_file_scope) <<
SizeRange;
IDecl->setInvalidDecl(); IDecl->setInvalidDecl();
} else { } else {
// C99 6.7.5.2p2: If an identifier is declared to be an object with // C99 6.7.5.2p2: If an identifier is declared to be an object with
// static storage duration, it shall not have a variable length array. // static storage duration, it shall not have a variable length array.
if (IDecl->getStorageClass() == VarDecl::Static) { if (IDecl->getStorageClass() == VarDecl::Static) {
Diag(IDecl->getLocation(), diag::err_vla_decl_has_static_storage); Diag(IDecl->getLocation(), diag::err_vla_decl_has_static_storage)
<< SizeRange;
IDecl->setInvalidDecl(); IDecl->setInvalidDecl();
} else if (IDecl->getStorageClass() == VarDecl::Extern) { } else if (IDecl->getStorageClass() == VarDecl::Extern) {
Diag(IDecl->getLocation(), diag::err_vla_decl_has_extern_linkage); Diag(IDecl->getLocation(), diag::err_vla_decl_has_extern_linkage)
<< SizeRange;
IDecl->setInvalidDecl(); IDecl->setInvalidDecl();
} }
} }