Change indentation of a whole bunch of code, no real changes here.

llvm-svn: 18843
This commit is contained in:
Chris Lattner 2004-12-12 23:49:37 +00:00
parent 14d07db44d
commit a199e3c1e2
1 changed files with 99 additions and 99 deletions

View File

@ -305,9 +305,7 @@ bool ADCE::doADCE() {
} }
}); });
// Find the first postdominator of the entry node that is alive. Make it the // All blocks being live is a common case, handle it specially.
// new entry node...
//
if (AliveBlocks.size() == Func->size()) { // No dead blocks? if (AliveBlocks.size() == Func->size()) { // No dead blocks?
for (Function::iterator I = Func->begin(), E = Func->end(); I != E; ++I) { for (Function::iterator I = Func->begin(), E = Func->end(); I != E; ++I) {
// Loop over all of the instructions in the function deleting instructions // Loop over all of the instructions in the function deleting instructions
@ -319,123 +317,125 @@ bool ADCE::doADCE() {
// unconditional branch), is not needed to make the decision of where to // unconditional branch), is not needed to make the decision of where to
// go to, because all outgoing edges go to the same place. We must remove // go to, because all outgoing edges go to the same place. We must remove
// the use of the condition (because it's probably dead), so we convert // the use of the condition (because it's probably dead), so we convert
// the terminator to a conditional branch. // the terminator to an unconditional branch.
// //
TerminatorInst *TI = I->getTerminator(); TerminatorInst *TI = I->getTerminator();
if (!LiveSet.count(TI)) if (!LiveSet.count(TI))
convertToUnconditionalBranch(TI); convertToUnconditionalBranch(TI);
} }
return MadeChanges;
}
// If the entry node is dead, insert a new entry node to eliminate the entry
// node as a special case.
//
if (!AliveBlocks.count(&Func->front())) {
BasicBlock *NewEntry = new BasicBlock();
new BranchInst(&Func->front(), NewEntry);
Func->getBasicBlockList().push_front(NewEntry);
AliveBlocks.insert(NewEntry); // This block is always alive!
LiveSet.insert(NewEntry->getTerminator()); // The branch is live
}
} else { // If there are some blocks dead... // Loop over all of the alive blocks in the function. If any successor
// If the entry node is dead, insert a new entry node to eliminate the entry // blocks are not alive, we adjust the outgoing branches to branch to the
// node as a special case. // first live postdominator of the live block, adjusting any PHI nodes in
// // the block to reflect this.
if (!AliveBlocks.count(&Func->front())) { //
BasicBlock *NewEntry = new BasicBlock(); for (Function::iterator I = Func->begin(), E = Func->end(); I != E; ++I)
new BranchInst(&Func->front(), NewEntry); if (AliveBlocks.count(I)) {
Func->getBasicBlockList().push_front(NewEntry); BasicBlock *BB = I;
AliveBlocks.insert(NewEntry); // This block is always alive! TerminatorInst *TI = BB->getTerminator();
LiveSet.insert(NewEntry->getTerminator()); // The branch is live
}
// Loop over all of the alive blocks in the function. If any successor
// blocks are not alive, we adjust the outgoing branches to branch to the
// first live postdominator of the live block, adjusting any PHI nodes in
// the block to reflect this.
//
for (Function::iterator I = Func->begin(), E = Func->end(); I != E; ++I)
if (AliveBlocks.count(I)) {
BasicBlock *BB = I;
TerminatorInst *TI = BB->getTerminator();
// If the terminator instruction is alive, but the block it is contained // If the terminator instruction is alive, but the block it is contained
// in IS alive, this means that this terminator is a conditional branch // in IS alive, this means that this terminator is a conditional branch on
// on a condition that doesn't matter. Make it an unconditional branch // a condition that doesn't matter. Make it an unconditional branch to
// to ONE of the successors. This has the side effect of dropping a use // ONE of the successors. This has the side effect of dropping a use of
// of the conditional value, which may also be dead. // the conditional value, which may also be dead.
if (!LiveSet.count(TI)) if (!LiveSet.count(TI))
TI = convertToUnconditionalBranch(TI); TI = convertToUnconditionalBranch(TI);
// Loop over all of the successors, looking for ones that are not alive. // Loop over all of the successors, looking for ones that are not alive.
// We cannot save the number of successors in the terminator instruction // We cannot save the number of successors in the terminator instruction
// here because we may remove them if we don't have a postdominator... // here because we may remove them if we don't have a postdominator...
// //
for (unsigned i = 0; i != TI->getNumSuccessors(); ++i) for (unsigned i = 0; i != TI->getNumSuccessors(); ++i)
if (!AliveBlocks.count(TI->getSuccessor(i))) { if (!AliveBlocks.count(TI->getSuccessor(i))) {
// Scan up the postdominator tree, looking for the first // Scan up the postdominator tree, looking for the first
// postdominator that is alive, and the last postdominator that is // postdominator that is alive, and the last postdominator that is
// dead... // dead...
//
PostDominatorTree::Node *LastNode = DT[TI->getSuccessor(i)];
// There is a special case here... if there IS no post-dominator for
// the block we have no owhere to point our branch to. Instead,
// convert it to a return. This can only happen if the code branched
// into an infinite loop. Note that this may not be desirable,
// because we _are_ altering the behavior of the code. This is a well
// known drawback of ADCE, so in the future if we choose to revisit
// the decision, this is where it should be.
//
if (LastNode == 0) { // No postdominator!
// Call RemoveSuccessor to transmogrify the terminator instruction
// to not contain the outgoing branch, or to create a new terminator
// if the form fundamentally changes (i.e., unconditional branch to
// return). Note that this will change a branch into an infinite
// loop into a return instruction!
// //
PostDominatorTree::Node *LastNode = DT[TI->getSuccessor(i)]; RemoveSuccessor(TI, i);
// There is a special case here... if there IS no post-dominator for // RemoveSuccessor may replace TI... make sure we have a fresh
// the block we have no owhere to point our branch to. Instead, // pointer... and e variable.
// convert it to a return. This can only happen if the code
// branched into an infinite loop. Note that this may not be
// desirable, because we _are_ altering the behavior of the code.
// This is a well known drawback of ADCE, so in the future if we
// choose to revisit the decision, this is where it should be.
// //
if (LastNode == 0) { // No postdominator! TI = BB->getTerminator();
// Call RemoveSuccessor to transmogrify the terminator instruction
// to not contain the outgoing branch, or to create a new
// terminator if the form fundamentally changes (i.e.,
// unconditional branch to return). Note that this will change a
// branch into an infinite loop into a return instruction!
//
RemoveSuccessor(TI, i);
// RemoveSuccessor may replace TI... make sure we have a fresh // Rescan this successor...
// pointer... and e variable. --i;
// } else {
TI = BB->getTerminator(); PostDominatorTree::Node *NextNode = LastNode->getIDom();
// Rescan this successor... while (!AliveBlocks.count(NextNode->getBlock())) {
--i; LastNode = NextNode;
} else { NextNode = NextNode->getIDom();
PostDominatorTree::Node *NextNode = LastNode->getIDom(); }
while (!AliveBlocks.count(NextNode->getBlock())) {
LastNode = NextNode;
NextNode = NextNode->getIDom();
}
// Get the basic blocks that we need... // Get the basic blocks that we need...
BasicBlock *LastDead = LastNode->getBlock(); BasicBlock *LastDead = LastNode->getBlock();
BasicBlock *NextAlive = NextNode->getBlock(); BasicBlock *NextAlive = NextNode->getBlock();
// Make the conditional branch now go to the next alive block... // Make the conditional branch now go to the next alive block...
TI->getSuccessor(i)->removePredecessor(BB); TI->getSuccessor(i)->removePredecessor(BB);
TI->setSuccessor(i, NextAlive); TI->setSuccessor(i, NextAlive);
// If there are PHI nodes in NextAlive, we need to add entries to // If there are PHI nodes in NextAlive, we need to add entries to
// the PHI nodes for the new incoming edge. The incoming values // the PHI nodes for the new incoming edge. The incoming values
// should be identical to the incoming values for LastDead. // should be identical to the incoming values for LastDead.
// //
for (BasicBlock::iterator II = NextAlive->begin(); for (BasicBlock::iterator II = NextAlive->begin();
isa<PHINode>(II); ++II) { isa<PHINode>(II); ++II) {
PHINode *PN = cast<PHINode>(II); PHINode *PN = cast<PHINode>(II);
if (LiveSet.count(PN)) { // Only modify live phi nodes if (LiveSet.count(PN)) { // Only modify live phi nodes
// Get the incoming value for LastDead... // Get the incoming value for LastDead...
int OldIdx = PN->getBasicBlockIndex(LastDead); int OldIdx = PN->getBasicBlockIndex(LastDead);
assert(OldIdx != -1 &&"LastDead is not a pred of NextAlive!"); assert(OldIdx != -1 &&"LastDead is not a pred of NextAlive!");
Value *InVal = PN->getIncomingValue(OldIdx); Value *InVal = PN->getIncomingValue(OldIdx);
// Add an incoming value for BB now... // Add an incoming value for BB now...
PN->addIncoming(InVal, BB); PN->addIncoming(InVal, BB);
}
} }
} }
} }
}
// Now loop over all of the instructions in the basic block, deleting // Now loop over all of the instructions in the basic block, deleting
// dead instructions. This is so that the next sweep over the program // dead instructions. This is so that the next sweep over the program
// can safely delete dead instructions without other dead instructions // can safely delete dead instructions without other dead instructions
// still referring to them. // still referring to them.
// //
deleteDeadInstructionsInLiveBlock(BB); deleteDeadInstructionsInLiveBlock(BB);
} }
}
// Loop over all of the basic blocks in the function, dropping references of // Loop over all of the basic blocks in the function, dropping references of
// the dead basic blocks. We must do this after the previous step to avoid // the dead basic blocks. We must do this after the previous step to avoid