maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[Tooling][libclang] Remove unused CompilationDatabase::MappedSources 

Summary:
This field is never assigned to and it's only ever read from libclang.
This patch removes it and adapts libclang to return constants.

Reviewers: klimek, bkramer

Reviewed By: klimek

Subscribers: cfe-commits, klimek

Differential Revision: https://reviews.llvm.org/D32351

llvm-svn: 303635
This commit is contained in:
Krasimir Georgiev 2017-05-23 13:50:43 +00:00
parent f01af686a2
commit a192804293
2 changed files with 9 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
clang/include/clang/Tooling/CompilationDatabase.h
View File

@ -60,16 +60,6 @@ struct CompileCommand {
/// The output file associated with the command.
std::string Output;
/// \brief An optional mapping from each file's path to its content for all
/// files needed for the compilation that are not available via the file
/// system.
///
/// Note that a tool implementation is required to fall back to the file
/// system if a source file is not provided in the mapped sources, as
/// compilation databases will usually not provide all files in mapped sources
/// for performance reasons.
std::vector<std::pair<std::string, std::string> > MappedSources;
};
/// \brief Interface for compilation databases.

31
clang/tools/libclang/CXCompilationDatabase.cpp
View File

@ -145,36 +145,23 @@ clang_CompileCommand_getArg(CXCompileCommand CCmd, unsigned Arg)
unsigned
clang_CompileCommand_getNumMappedSources(CXCompileCommand CCmd)
{
if (!CCmd)
return 0;
return static_cast<CompileCommand *>(CCmd)->MappedSources.size();
// Left here for backward compatibility. No mapped sources exists in the C++
// backend anymore.
return 0;
}
CXString
clang_CompileCommand_getMappedSourcePath(CXCompileCommand CCmd, unsigned I)
{
if (!CCmd)
return cxstring::createNull();
CompileCommand *Cmd = static_cast<CompileCommand *>(CCmd);
if (I >= Cmd->MappedSources.size())
return cxstring::createNull();
return cxstring::createRef(Cmd->MappedSources[I].first.c_str());
// Left here for backward compatibility. No mapped sources exists in the C++
// backend anymore.
return cxstring::createNull();
}
CXString
clang_CompileCommand_getMappedSourceContent(CXCompileCommand CCmd, unsigned I)
{
if (!CCmd)
return cxstring::createNull();
CompileCommand *Cmd = static_cast<CompileCommand *>(CCmd);
if (I >= Cmd->MappedSources.size())
return cxstring::createNull();
return cxstring::createRef(Cmd->MappedSources[I].second.c_str());
// Left here for backward compatibility. No mapped sources exists in the C++
// backend anymore.
return cxstring::createNull();
}