Simplify logic for avoiding concatenation after numeric constants.

I threw in a couple of test cases for UD-suffixes -- already working, but
it wasn't immediately obvious to me.

llvm-svn: 174767
This commit is contained in:
Jordan Rose 2013-02-08 22:30:31 +00:00
parent 00d1b59184
commit a08ed5965c
2 changed files with 14 additions and 7 deletions

View File

@ -12,9 +12,9 @@
//===----------------------------------------------------------------------===//
#include "clang/Lex/TokenConcatenation.h"
#include "clang/Basic/CharInfo.h"
#include "clang/Lex/Preprocessor.h"
#include "llvm/Support/ErrorHandling.h"
#include <cctype>
using namespace clang;
@ -240,13 +240,12 @@ bool TokenConcatenation::AvoidConcat(const Token &PrevPrevTok,
return IsIdentifierStringPrefix(PrevTok);
case tok::numeric_constant:
return isalnum(FirstChar) || Tok.is(tok::numeric_constant) ||
FirstChar == '+' || FirstChar == '-' || FirstChar == '.' ||
(PP.getLangOpts().CPlusPlus11 && FirstChar == '_');
return isPreprocessingNumberBody(FirstChar) ||
FirstChar == '+' || FirstChar == '-';
case tok::period: // ..., .*, .1234
return (FirstChar == '.' && PrevPrevTok.is(tok::period)) ||
isdigit(FirstChar) ||
(PP.getLangOpts().CPlusPlus && FirstChar == '*');
isDigit(FirstChar) ||
(PP.getLangOpts().CPlusPlus && FirstChar == '*');
case tok::amp: // &&
return FirstChar == '&';
case tok::plus: // ++

View File

@ -1,4 +1,4 @@
// RUN: %clang_cc1 -E %s -o - | FileCheck -strict-whitespace %s
// RUN: %clang_cc1 -E -std=c++11 %s -o - | FileCheck -strict-whitespace %s
#define y(a) ..a
@ -37,3 +37,11 @@ F: >>equal
#define TYPEDEF(guid) typedef [uuid(guid)]
TYPEDEF(66504301-BE0F-101A-8BBB-00AA00300CAB) long OLE_COLOR;
// CHECK: typedef [uuid(66504301-BE0F-101A-8BBB-00AA00300CAB)] long OLE_COLOR;
// Be careful with UD-suffixes.
#define StrSuffix() "abc"_suffix
#define IntSuffix() 123_suffix
UD: StrSuffix()ident
UD: IntSuffix()ident
// CHECK: UD: "abc"_suffix ident
// CHECK: UD: 123_suffix ident