maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Make the getNamedFunction and getNamedGlobal methods be const. They don't 

change the module in any way and we should enforce that.

llvm-svn: 28588
This commit is contained in:
Reid Spencer 2006-05-31 16:40:28 +00:00
parent 735e3f76a8
commit 9fef163d19
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/include/llvm/Module.h
View File

@ -179,7 +179,7 @@ public:
/// getNamedFunction - Return the first function in the module with the /// getNamedFunction - Return the first function in the module with the
/// specified name, of arbitrary type. This method returns null if a function /// specified name, of arbitrary type. This method returns null if a function
/// with the specified name is not found. /// with the specified name is not found.
Function *getNamedFunction(const std::string &Name); Function *getNamedFunction(const std::string &Name) const;
/// @} /// @}
/// @name Global Variable Accessors /// @name Global Variable Accessors
@ -197,7 +197,7 @@ public:
/// getNamedGlobal - Return the first global variable in the module with the /// getNamedGlobal - Return the first global variable in the module with the
/// specified name, of arbitrary type. This method returns null if a global /// specified name, of arbitrary type. This method returns null if a global
/// with the specified name is not found. /// with the specified name is not found.
GlobalVariable *getNamedGlobal(const std::string &Name); GlobalVariable *getNamedGlobal(const std::string &Name) const;
/// @} /// @}
/// @name Type Accessors /// @name Type Accessors

16
llvm/lib/VMCore/Module.cpp
View File

@ -250,16 +250,16 @@ Function *Module::getMainFunction() {
/// specified name, of arbitrary type. This method returns null if a function /// specified name, of arbitrary type. This method returns null if a function
/// with the specified name is not found. /// with the specified name is not found.
/// ///
Function *Module::getNamedFunction(const std::string &Name) { Function *Module::getNamedFunction(const std::string &Name) const {
// Loop over all of the functions, looking for the function desired // Loop over all of the functions, looking for the function desired
Function *Found = 0; const Function *Found = 0;
for (iterator I = begin(), E = end(); I != E; ++I) for (const_iterator I = begin(), E = end(); I != E; ++I)
if (I->getName() == Name) if (I->getName() == Name)
if (I->isExternal()) if (I->isExternal())
Found = I; Found = I;
else else
return I; return const_cast<Function*>(&(*I));
return Found; // Non-external function not found... return const_cast<Function*>(Found); // Non-external function not found...
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
@ -287,13 +287,13 @@ GlobalVariable *Module::getGlobalVariable(const std::string &Name,
/// specified name, of arbitrary type. This method returns null if a global /// specified name, of arbitrary type. This method returns null if a global
/// with the specified name is not found. /// with the specified name is not found.
/// ///
GlobalVariable *Module::getNamedGlobal(const std::string &Name) { GlobalVariable *Module::getNamedGlobal(const std::string &Name) const {
// FIXME: This would be much faster with a symbol table that doesn't // FIXME: This would be much faster with a symbol table that doesn't
// discriminate based on type! // discriminate based on type!
for (global_iterator I = global_begin(), E = global_end(); for (const_global_iterator I = global_begin(), E = global_end();
I != E; ++I) I != E; ++I)
if (I->getName() == Name) if (I->getName() == Name)
return I; return const_cast<GlobalVariable*>(&(*I));
return 0; return 0;
} }