From 9e7f505515346b1580b99e8a9db01413c6a751dd Mon Sep 17 00:00:00 2001 From: Timur Iskhodzhanov Date: Thu, 7 Nov 2013 13:34:02 +0000 Subject: [PATCH] Minor refinement of VTableBuilder.h: fix wrong indentation, rename a struct field with a more appropriate name llvm-svn: 194202 --- clang/include/clang/AST/VTableBuilder.h | 24 +++++++++++------------- clang/lib/AST/VTableBuilder.cpp | 4 ++-- clang/lib/CodeGen/MicrosoftCXXABI.cpp | 6 +++--- 3 files changed, 16 insertions(+), 18 deletions(-) diff --git a/clang/include/clang/AST/VTableBuilder.h b/clang/include/clang/AST/VTableBuilder.h index 6a87ab992a42..4e451324d734 100644 --- a/clang/include/clang/AST/VTableBuilder.h +++ b/clang/include/clang/AST/VTableBuilder.h @@ -233,23 +233,21 @@ public: } vtable_component_iterator vtable_component_begin() const { - return VTableComponents.get(); + return VTableComponents.get(); } vtable_component_iterator vtable_component_end() const { - return VTableComponents.get()+NumVTableComponents; + return VTableComponents.get() + NumVTableComponents; } - uint64_t getNumVTableThunks() const { - return NumVTableThunks; - } + uint64_t getNumVTableThunks() const { return NumVTableThunks; } vtable_thunk_iterator vtable_thunk_begin() const { - return VTableThunks.get(); + return VTableThunks.get(); } vtable_thunk_iterator vtable_thunk_end() const { - return VTableThunks.get()+NumVTableThunks; + return VTableThunks.get() + NumVTableThunks; } uint64_t getAddressPoint(BaseSubobject Base) const { @@ -414,27 +412,27 @@ public: /// This is the offset of the vfptr from the start of the last vbase, or the /// complete type if there are no virtual bases. - CharUnits VFTableOffset; + CharUnits VFPtrOffset; /// Method's index in the vftable. uint64_t Index; MethodVFTableLocation() - : VBTableIndex(0), VBase(0), VFTableOffset(CharUnits::Zero()), + : VBTableIndex(0), VBase(0), VFPtrOffset(CharUnits::Zero()), Index(0) {} MethodVFTableLocation(uint64_t VBTableIndex, const CXXRecordDecl *VBase, - CharUnits VFTableOffset, uint64_t Index) + CharUnits VFPtrOffset, uint64_t Index) : VBTableIndex(VBTableIndex), VBase(VBase), - VFTableOffset(VFTableOffset), Index(Index) {} + VFPtrOffset(VFPtrOffset), Index(Index) {} bool operator<(const MethodVFTableLocation &other) const { if (VBTableIndex != other.VBTableIndex) { assert(VBase != other.VBase); return VBTableIndex < other.VBTableIndex; } - if (VFTableOffset != other.VFTableOffset) - return VFTableOffset < other.VFTableOffset; + if (VFPtrOffset != other.VFPtrOffset) + return VFPtrOffset < other.VFPtrOffset; if (Index != other.Index) return Index < other.Index; return false; diff --git a/clang/lib/AST/VTableBuilder.cpp b/clang/lib/AST/VTableBuilder.cpp index efaa313a67b8..142f55029699 100644 --- a/clang/lib/AST/VTableBuilder.cpp +++ b/clang/lib/AST/VTableBuilder.cpp @@ -3317,7 +3317,7 @@ void MicrosoftVTableContext::dumpMethodLocations( IndicesMap[I->second] = MethodName; } - if (!I->second.VFTableOffset.isZero() || I->second.VBTableIndex != 0) + if (!I->second.VFPtrOffset.isZero() || I->second.VBTableIndex != 0) HasNonzeroOffset = true; } @@ -3333,7 +3333,7 @@ void MicrosoftVTableContext::dumpMethodLocations( I = IndicesMap.begin(), E = IndicesMap.end(); I != E; ++I) { - CharUnits VFPtrOffset = I->first.VFTableOffset; + CharUnits VFPtrOffset = I->first.VFPtrOffset; uint64_t VBIndex = I->first.VBTableIndex; if (HasNonzeroOffset && (VFPtrOffset != LastVFPtrOffset || VBIndex != LastVBIndex)) { diff --git a/clang/lib/CodeGen/MicrosoftCXXABI.cpp b/clang/lib/CodeGen/MicrosoftCXXABI.cpp index 6415749e2df9..9c11893c17f7 100644 --- a/clang/lib/CodeGen/MicrosoftCXXABI.cpp +++ b/clang/lib/CodeGen/MicrosoftCXXABI.cpp @@ -128,7 +128,7 @@ public: // In this case, we just use a generic pointer type. // FIXME: might want to have a more precise type in the non-virtual // multiple inheritance case. - if (ML.VBase || !ML.VFTableOffset.isZero()) + if (ML.VBase || !ML.VFPtrOffset.isZero()) return 0; } return MD->getParent(); @@ -600,7 +600,7 @@ llvm::Value *MicrosoftCXXABI::adjustThisArgumentForVirtualCall( unsigned AS = cast(This->getType())->getAddressSpace(); llvm::Type *charPtrTy = CGF.Int8Ty->getPointerTo(AS); - CharUnits StaticOffset = ML.VFTableOffset; + CharUnits StaticOffset = ML.VFPtrOffset; if (ML.VBase) { bool AvoidVirtualOffset = false; if (isa(MD) && GD.getDtorType() == Dtor_Base) { @@ -723,7 +723,7 @@ llvm::Value *MicrosoftCXXABI::adjustThisParameterInVirtualFunctionPrologue( MicrosoftVTableContext::MethodVFTableLocation ML = CGM.getMicrosoftVTableContext().getMethodVFTableLocation(LookupGD); - CharUnits Adjustment = ML.VFTableOffset; + CharUnits Adjustment = ML.VFPtrOffset; if (ML.VBase) { const ASTRecordLayout &DerivedLayout = CGF.getContext().getASTRecordLayout(MD->getParent());