maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix an incorrect comment in builder-api-test. 

Also address post commit cleanups that were missed.

PiperOrigin-RevId: 237122077
This commit is contained in:
Nicolas Vasilache 2019-03-06 14:34:26 -08:00 committed by jpienaar
parent 7c0b9e8b62
commit 9e425a06f7
2 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mlir/lib/EDSC/Helpers.cpp
View File

@ -18,8 +18,6 @@
#include "mlir/EDSC/Helpers.h"
#include "mlir/IR/AffineExpr.h"
#include "mlir/StandardOps/Ops.h"
#include "third_party/llvm/llvm/projects/google_mlir/include/mlir/EDSC/Builders.h"
#include "third_party/llvm/llvm/projects/google_mlir/include/mlir/EDSC/Helpers.h"
using namespace mlir;
using namespace mlir::edsc;

11
mlir/test/EDSC/builder-api-test.cpp
View File

@ -1,5 +1,4 @@
//===- builder-api-test.cpp - Tests for Declarative Builder APIs
//-----------===//
//===- builder-api-test.cpp - Tests for Declarative Builder APIs ----------===//
//
// Copyright 2019 The MLIR Authors.
//
@ -211,12 +210,10 @@ TEST_FUNC(builder_blocks_eager) {
// clang-format off
BlockHandle b1, b2;
{ // Toplevel function scope.
BR(&b1, {&arg1, &arg2}, {c1, c2}); // eagerly builds a new block for b1
// We cannot construct b2 eagerly with a `BR(&b2, ...)` call from within b1
// because it would result in b2 being nested under b1 which is not what we
// want in this test.
// Build a new block for b1 eagerly.
BR(&b1, {&arg1, &arg2}, {c1, c2});
// Construct a new block b2 explicitly with a branch into b1.
BlockBuilder(&b2, {&arg3, &arg4})({
// Instead, construct explicitly
BR(b1, {arg3, arg4}),
});
/// And come back to append into b1 once b2 exists.