[libcxx testing] Remove ALLOW_RETRIES from sleep_for.pass.cpp

Operating systems are best effort by default, so we cannot assume that
sleep-like APIs return as soon as we'd like.

Even if a sleep-like API returns when we want it to, the potential for
preemption means that attempts to measure time are subject to delays.
This commit is contained in:
David Zarzycki 2020-05-12 06:44:37 -04:00
parent 077d2d6802
commit 9e32bf550d
1 changed files with 24 additions and 27 deletions

View File

@ -8,8 +8,6 @@
// //
// UNSUPPORTED: libcpp-has-no-threads // UNSUPPORTED: libcpp-has-no-threads
// ALLOW_RETRIES: 2
// This test uses the POSIX header <sys/time.h> which Windows doesn't provide // This test uses the POSIX header <sys/time.h> which Windows doesn't provide
// UNSUPPORTED: windows // UNSUPPORTED: windows
@ -38,34 +36,33 @@ void sig_action(int) {}
int main(int, char**) int main(int, char**)
{ {
int ec; int ec;
struct sigaction action; struct sigaction action;
action.sa_handler = &sig_action; action.sa_handler = &sig_action;
sigemptyset(&action.sa_mask); sigemptyset(&action.sa_mask);
action.sa_flags = 0; action.sa_flags = 0;
ec = sigaction(SIGALRM, &action, nullptr); ec = sigaction(SIGALRM, &action, nullptr);
assert(!ec); assert(!ec);
struct itimerval it; struct itimerval it;
std::memset(&it, 0, sizeof(itimerval)); std::memset(&it, 0, sizeof(itimerval));
it.it_value.tv_sec = 0; it.it_value.tv_sec = 0;
it.it_value.tv_usec = 250000; it.it_value.tv_usec = 250000;
// This will result in a SIGALRM getting fired resulting in the nanosleep // This will result in a SIGALRM getting fired resulting in the nanosleep
// inside sleep_for getting EINTR. // inside sleep_for getting EINTR.
ec = setitimer(ITIMER_REAL, &it, nullptr); ec = setitimer(ITIMER_REAL, &it, nullptr);
assert(!ec); assert(!ec);
typedef std::chrono::system_clock Clock; typedef std::chrono::system_clock Clock;
typedef Clock::time_point time_point; typedef Clock::time_point time_point;
std::chrono::milliseconds ms(500); std::chrono::milliseconds ms(500);
time_point t0 = Clock::now(); time_point t0 = Clock::now();
std::this_thread::sleep_for(ms); std::this_thread::sleep_for(ms);
time_point t1 = Clock::now(); time_point t1 = Clock::now();
std::chrono::nanoseconds ns = (t1 - t0) - ms; // NOTE: Operating systems are (by default) best effort and therefore we may
std::chrono::nanoseconds err = 5 * ms / 100; // have slept longer, perhaps much longer than we requested.
// The time slept is within 5% of 500ms assert(t1 - t0 >= ms);
assert(std::abs(ns.count()) < err.count());
return 0; return 0;
} }