maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Restructure DereferenceChecker slightly to handle caching out when we would report a null dereference more than once. 

llvm-svn: 89526
This commit is contained in:
Ted Kremenek 2009-11-21 01:50:48 +00:00
parent caf2c51fad
commit 9d6daf2cc4
1 changed files with 22 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
clang/lib/Analysis/DereferenceChecker.cpp
View File

@ -82,29 +82,32 @@ void DereferenceChecker::VisitLocation(CheckerContext &C, const Stmt *S,
// The explicit NULL case.
if (nullState) {
// Generate an error node.
ExplodedNode *N = C.GenerateNode(S, nullState, true);
if (N) {
if (!notNullState) {
// We know that 'location' cannot be non-null. This is what
// we call an "explicit" null dereference.
if (!BT_null)
BT_null = new BuiltinBug("Null pointer dereference",
"Dereference of null pointer");
EnhancedBugReport *report =
new EnhancedBugReport(*BT_null, BT_null->getDescription(), N);
report->addVisitorCreator(bugreporter::registerTrackNullOrUndefValue,
bugreporter::GetDerefExpr(N));
C.EmitReport(report);
if (!notNullState) {
// Generate an error node.
ExplodedNode *N = C.GenerateNode(S, nullState, true);
if (!N)
return;
}
// We know that 'location' cannot be non-null. This is what
// we call an "explicit" null dereference.
if (!BT_null)
BT_null = new BuiltinBug("Null pointer dereference",
"Dereference of null pointer");
EnhancedBugReport *report =
new EnhancedBugReport(*BT_null, BT_null->getDescription(), N);
report->addVisitorCreator(bugreporter::registerTrackNullOrUndefValue,
bugreporter::GetDerefExpr(N));
C.EmitReport(report);
return;
}
else {
// Otherwise, we have the case where the location could either be
// null or not-null. Record the error node as an "implicit" null
// dereference.
ImplicitNullDerefNodes.push_back(N);
// dereference.
if (ExplodedNode *N = C.GenerateNode(S, nullState, true))
ImplicitNullDerefNodes.push_back(N);
}
}