maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Revert "TarWriter: Only use 137 of the 155 prefix bytes." 

This reverts commit 90d6ed144c.
Breaks check-llvm. Revert while I investigate.
This commit is contained in:
Nico Weber 2020-04-27 13:34:04 -04:00
parent d931b09a16
commit 9d1fc92b14
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
llvm/lib/Support/TarWriter.cpp
View File

@ -131,17 +131,7 @@ static bool splitUstar(StringRef Path, StringRef &Prefix, StringRef &Name) {
return true;
}
// tar 1.13 and earlier unconditionally look at the tar header interpreted
// as an 'oldgnu_header', which has an 'isextended' byte at offset 482 in the
// header, corresponding to offset 137 in the prefix. That's the version of
// tar in gnuwin, so only use 137 of the 155 bytes in the prefix. This means
// we'll need a pax header after 237 bytes of path instead of after 255,
// but in return paths up to 237 bytes work with gnuwin, instead of just
// 137 bytes of directory + 100 bytes of basename previously.
// (tar-1.13 also doesn't support pax headers, but in practice all paths in
// llvm's test suite are short enough for that to not matter.)
const int MaxPrefix = 137;
size_t Sep = Path.rfind('/', MaxPrefix + 1);
size_t Sep = Path.rfind('/', sizeof(UstarHeader::Prefix) + 1);
if (Sep == StringRef::npos)
return false;
if (Path.size() - Sep - 1 >= sizeof(UstarHeader::Name))