maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[NFC] Refactor the tuple of symbol information with structure for llvm-objdump 

SUMMARY:

address  the comment of
https://reviews.llvm.org/D74240#inline-676127
https://reviews.llvm.org/D74240#inline-675875

Reviewers: daltenty, jason liu, xiangling liao
Subscribers: wuzish, nemanjai, hiraditya

Differential Revision: https://reviews.llvm.org/D74240
This commit is contained in:
diggerlin 2020-02-11 14:41:24 -05:00
parent 2040831d05
commit 9c1a88c964
2 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
llvm/include/llvm/MC/MCDisassembler/MCDisassembler.h
View File

@ -22,15 +22,19 @@ struct SymbolInfoTy {
StringRef Name;
uint8_t Type;
SymbolInfoTy(uint64_t Addr, StringRef Name, uint8_t Type):
Addr(Addr),Name(Name),Type(Type) {};
SymbolInfoTy(uint64_t Addr, StringRef Name, uint8_t Type)
: Addr(Addr), Name(Name), Type(Type){};
friend bool operator<(const SymbolInfoTy &P1, const SymbolInfoTy &P2) {
return std::tie(P1.Addr, P1.Name, P1.Type) <
std::tie(P2.Addr, P2.Name, P2.Type);
}
};
using SectionSymbolsTy = std::vector<SymbolInfoTy>;
template <typename T> class ArrayRef;
class StringRef;
class MCContext;
class MCInst;
class MCSubtargetInfo;

10
llvm/tools/llvm-objdump/llvm-objdump.cpp
View File

@ -341,16 +341,6 @@ static StringSet<> DisasmFuncsSet;
StringSet<> FoundSectionSet;
static StringRef ToolName;
static bool operator<(const SymbolInfoTy& P1 ,const SymbolInfoTy& P2) {
if (P1.Addr < P2.Addr)
return true;
if (P1.Addr == P2.Addr)
return P1.Name < P2.Name;
return false;
}
namespace {
struct FilterResult {
// True if the section should not be skipped.