forked from OSchip/llvm-project
[lldb/test] Fix InvalidScriptedThread windows test failure
This patch should fix a Windows test failure for the InvalidScriptedThread test: https://lab.llvm.org/buildbot/#/builders/83/builds/12571 This refactors the test to stop using python `tempfile` since it's not supported on Windows and creates a logfile at runtime in the test folder. Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
This commit is contained in:
parent
83087c096a
commit
9c144b3b0d
|
@ -47,6 +47,9 @@ class ScriptedProcesTestCase(TestBase):
|
|||
self.build()
|
||||
target = self.dbg.CreateTarget(self.getBuildArtifact("a.out"))
|
||||
self.assertTrue(target, VALID_TARGET)
|
||||
log_file = self.getBuildArtifact('thread.log')
|
||||
self.runCmd("log enable lldb thread -f " + log_file)
|
||||
self.assertTrue(os.path.isfile(log_file))
|
||||
|
||||
os.environ['SKIP_SCRIPTED_PROCESS_LAUNCH'] = '1'
|
||||
def cleanup():
|
||||
|
@ -61,8 +64,7 @@ class ScriptedProcesTestCase(TestBase):
|
|||
launch_info.SetProcessPluginName("ScriptedProcess")
|
||||
launch_info.SetScriptedProcessClassName("invalid_scripted_process.InvalidScriptedProcess")
|
||||
error = lldb.SBError()
|
||||
with tempfile.NamedTemporaryFile() as log_file:
|
||||
self.runCmd("log enable lldb thread -f " + log_file.name)
|
||||
|
||||
process = target.Launch(launch_info, error)
|
||||
|
||||
self.assertTrue(error.Success(), error.GetCString())
|
||||
|
@ -70,8 +72,10 @@ class ScriptedProcesTestCase(TestBase):
|
|||
self.assertEqual(process.GetProcessID(), 666)
|
||||
self.assertEqual(process.GetNumThreads(), 0)
|
||||
|
||||
self.assertIn("Failed to get scripted thread registers data.".encode(),
|
||||
log_file.read())
|
||||
with open(log_file, 'r') as f:
|
||||
log = f.read()
|
||||
|
||||
self.assertIn("Failed to get scripted thread registers data.", log)
|
||||
|
||||
@skipIf(archs=no_match(['x86_64']))
|
||||
def test_scripted_process_and_scripted_thread(self):
|
||||
|
|
Loading…
Reference in New Issue