maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Support: Avoid unnecessary std::function for SignpostEmitterImpl::SignpostLog 

The destructor for SignPostEmitterImpl::SignpostLog is known statically. Avoid
the unnecessary vtable indirection through std::function in the std::unique_ptr
by turning LogDeleter into a struct. No real functionality change here.

Differential Revision: https://reviews.llvm.org/D100154
This commit is contained in:
Duncan P. N. Exon Smith 2021-04-08 16:20:31 -07:00
parent bf12b711f9
commit 9be4387434
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
llvm/lib/Support/Signposts.cpp
View File

@ -29,15 +29,17 @@ os_log_t *LogCreator() {
*X = os_log_create("org.llvm.signposts", OS_LOG_CATEGORY_POINTS_OF_INTEREST); *X = os_log_create("org.llvm.signposts", OS_LOG_CATEGORY_POINTS_OF_INTEREST);
return X; return X;
} }
void LogDeleter(os_log_t *X) { struct LogDeleter {
os_release(*X); void operator()(os_log_t *X) const {
delete X; os_release(*X);
} delete X;
}
};
} // end anonymous namespace } // end anonymous namespace
namespace llvm { namespace llvm {
class SignpostEmitterImpl { class SignpostEmitterImpl {
using LogPtrTy = std::unique_ptr<os_log_t, std::function<void(os_log_t *)>>; using LogPtrTy = std::unique_ptr<os_log_t, LogDeleter>;
using LogTy = LogPtrTy::element_type; using LogTy = LogPtrTy::element_type;
LogPtrTy SignpostLog; LogPtrTy SignpostLog;
@ -59,7 +61,7 @@ class SignpostEmitterImpl {
} }
public: public:
SignpostEmitterImpl() : SignpostLog(LogCreator(), LogDeleter) {} SignpostEmitterImpl() : SignpostLog(LogCreator()) {}
bool isEnabled() const { bool isEnabled() const {
if (SIGNPOSTS_AVAILABLE()) if (SIGNPOSTS_AVAILABLE())