[lldb][NFC] Remove all `setUp` overrides that only call the parent implementation

Summary:
A lot of our tests copied the setUp code from our TestSampleTest.py:

```
    def setUp(self):
        # Call super's setUp().
        TestBase.setUp(self)
```

This code does nothing unless we actually do any setUp work in there, so let's remove all these method definitions.

Reviewers: labath, JDevlieghere

Reviewed By: labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D71454
This commit is contained in:
Raphael Isemann 2019-12-13 12:24:23 +01:00
parent 3ca771ba59
commit 9bace26a69
55 changed files with 0 additions and 202 deletions

View File

@ -16,10 +16,6 @@ class ListenToModuleLoadedEvents (TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def test_receiving_breakpoint_added(self):
"""Test that we get breakpoint added events, waiting on event classes on the debugger"""
self.build()

View File

@ -6,9 +6,6 @@ class AproposTestCase(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
TestBase.setUp(self)
@no_debug_info_test
def test_apropos(self):
self.expect("apropos", error=True,

View File

@ -18,10 +18,6 @@ class ImportTestCase(TestBase):
"""Import some Python scripts by path and test them"""
self.run_test()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def run_test(self):
"""Import some Python scripts by path and test them."""

View File

@ -18,10 +18,6 @@ class Rdar12586188TestCase(TestBase):
"""Check that we handle an ImportError in a special way when command script importing files."""
self.run_test()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def run_test(self):
"""Check that we handle an ImportError in a special way when command script importing files."""

View File

@ -20,10 +20,6 @@ class FrameDisassembleTestCase(TestBase):
self.build()
self.frame_disassemble_test()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def frame_disassemble_test(self):
"""Sample test to ensure SBFrame::Disassemble produces SOME output"""
exe = self.getBuildArtifact("a.out")

View File

@ -14,10 +14,6 @@ class TestCalculatorMode(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def test__calculator_mode(self):
"""Test calling expressions in the dummy target."""
self.expect("expression 11 + 22", "11 + 22 didn't get the expected result", substrs=["33"])

View File

@ -30,10 +30,6 @@ class TestAllowJIT(TestBase):
self.main_source_file = lldb.SBFileSpec("main.c")
self.expr_options_test()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def expr_cmd_test(self):
(target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(self,
"Set a breakpoint here", self.main_source_file)

View File

@ -30,5 +30,3 @@ class ExprEntryBPTestCase(TestBase):
self.assertTrue(result.IsValid(), "Can't evaluate expression")
self.assertEqual(8, result.GetValueAsSigned())
def setUp(self):
TestBase.setUp(self)

View File

@ -13,10 +13,6 @@ class PersistentPtrUpdateTestCase(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def test(self):
"""Test that we can have persistent pointer variables"""
self.build()

View File

@ -25,10 +25,6 @@ class TestWeakSymbolsInExpressions(TestBase):
self.main_source_file = lldb.SBFileSpec("main.c")
self.do_test()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def run_weak_var_check (self, weak_varname, present):
# The expression will modify present_weak_int to signify which branch
# was taken. Set it to so we don't get confused by a previous run.

View File

@ -12,9 +12,6 @@ from lldbsuite.test import lldbutil
class TestArray(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
TestBase.setUp(self)
@skipUnlessDarwin
@skipIfDarwinEmbedded # <rdar://problem/33842388> frame diagnose doesn't work for armv7 or arm64
def test_array(self):

View File

@ -26,10 +26,6 @@ class TestFrameGuessLanguage(TestBase):
self.build()
self.do_test()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def check_language(self, thread, frame_no, test_lang):
frame = thread.frames[frame_no]
self.assertTrue(frame.IsValid(), "Frame %d was not valid."%(frame_no))

View File

@ -22,10 +22,6 @@ class TestFrameVar(TestBase):
self.build()
self.do_test()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def do_test(self):
exe = self.getBuildArtifact("a.out")

View File

@ -14,9 +14,6 @@ class RegisterCommandsTestCase(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
TestBase.setUp(self)
@skipIf(compiler="clang")
@skipIf(oslist=no_match(['linux']))
@skipIf(archs=no_match(['i386', 'x86_64']))

View File

@ -21,9 +21,6 @@ class MPXOffsetIntersectionTestCase(TestBase):
MPX_CONFIG_REGS = ('bndcfgu', 'bndstatus')
BND_VALUE = '{' + ' '.join(('0xff' for _ in range(16))) + '}'
def setUp(self):
TestBase.setUp(self)
@skipIf(oslist=no_match(['linux']))
@skipIf(archs=no_match(['x86_64']))
def test_mpx_registers_offset_intersection(self):

View File

@ -24,10 +24,6 @@ class TestStopHooks(TestBase):
self.main_source_file = lldb.SBFileSpec("main.c")
self.step_out_test()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def step_out_test(self):
(target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(self,
"Set a breakpoint here", self.main_source_file)

View File

@ -6,9 +6,6 @@ class VersionTestCase(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
TestBase.setUp(self)
@no_debug_info_test
def test_version(self):
# Should work even when people patch the output,

View File

@ -11,10 +11,6 @@ from lldbsuite.test import lldbplatform, lldbplatformutil
class TestWatchpointSetEnable(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def test_disable_works (self):
"""Set a watchpoint, disable it, and make sure it doesn't get hit."""
self.build()

View File

@ -20,10 +20,6 @@ class AddressBreakpointTestCase(TestBase):
self.build()
self.address_breakpoints()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def address_breakpoints(self):
"""Test address breakpoints set with shared library of SBAddress work correctly."""
exe = self.getBuildArtifact("a.out")

View File

@ -20,10 +20,6 @@ class BadAddressBreakpointTestCase(TestBase):
self.build()
self.address_breakpoints()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def address_breakpoints(self):
"""Test that breakpoints set on a bad address say they are bad."""
target, process, thread, bkpt = \

View File

@ -57,10 +57,6 @@ class BreakpointAutoContinue(TestBase):
return process
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def simple_auto_continue(self):
bpno = self.make_target_and_bkpt()
process = self.launch_it(lldb.eStateExited)

View File

@ -14,11 +14,6 @@ class TestBreakpointLanguage(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
# Find the line number to break inside main().
def check_location_file(self, bp, loc, test_name):
bp_loc = bp.GetLocationAtIndex(loc)
addr = bp_loc.GetAddress()

View File

@ -40,10 +40,6 @@ class TestScriptedResolver(TestBase):
self.build()
self.do_test_bad_options()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def make_target_and_import(self):
target = lldbutil.run_to_breakpoint_make_target(self)
interp = self.dbg.GetCommandInterpreter()

View File

@ -8,9 +8,6 @@ class TestDataFormatterCaching(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
TestBase.setUp(self)
def test_with_run_command(self):
"""
Test that hardcoded summary formatter matches aren't improperly cached.

View File

@ -14,10 +14,6 @@ class TypeSummaryListArgumentTestCase(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
@no_debug_info_test
def test_type_summary_list_with_arg(self):
"""Test that the 'type summary list' command handles command line arguments properly"""

View File

@ -22,10 +22,6 @@ class TestHistoryRecall(TestBase):
"""Test the !N and !-N functionality of the command interpreter."""
self.sample_test()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def sample_test(self):
interp = self.dbg.GetCommandInterpreter()
result = lldb.SBCommandReturnObject()

View File

@ -14,9 +14,6 @@ class LongjmpTestCase(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
TestBase.setUp(self)
@skipIfDarwin # llvm.org/pr16769: LLDB on Mac OS X dies in function ReadRegisterBytes in GDBRemoteRegisterContext.cpp
@skipIfFreeBSD # llvm.org/pr17214
@expectedFailureAll(oslist=["linux"], bugnumber="llvm.org/pr20231")

View File

@ -10,10 +10,6 @@ class TestPreRunLibraries(TestBase):
mydir = TestBase.compute_mydir(__file__)
NO_DEBUG_INFO_TESTCASE = True
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
@skipIf(oslist=no_match(['darwin','macos']))
def test(self):
"""Test that we find directly linked dylib pre-run."""

View File

@ -10,9 +10,6 @@ from lldbsuite.test import lldbutil
class TestStatsAPI(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
TestBase.setUp(self)
def test_stats_api(self):
self.build()
exe = self.getBuildArtifact("a.out")

View File

@ -17,10 +17,6 @@ class TestTailCallFrameSBAPI(TestBase):
self.build()
self.do_test()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def do_test(self):
exe = self.getBuildArtifact("a.out")

View File

@ -90,6 +90,3 @@ class TestArtificialFrameThreadStepOut1(TestBase):
self.assertEqual(frame4.GetDisplayFunctionName(), "main")
self.assertFalse(frame2.IsArtificial())
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)

View File

@ -14,10 +14,6 @@ class BacktraceLimitSettingTest(TestBase):
mydir = TestBase.compute_mydir(__file__)
NO_DEBUG_INFO_TESTCASE = True
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def test_backtrace_depth(self):
"""Test that the max-backtrace-depth setting limits backtraces."""
self.build()

View File

@ -24,10 +24,6 @@ class TsanCPPGlobalLocationTestCase(TestBase):
self.build()
self.tsan_tests()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def tsan_tests(self):
exe = self.getBuildArtifact("a.out")
self.expect(

View File

@ -24,10 +24,6 @@ class TsanGlobalLocationTestCase(TestBase):
self.build()
self.tsan_tests()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def tsan_tests(self):
exe = self.getBuildArtifact("a.out")
self.expect(

View File

@ -24,10 +24,6 @@ class TsanMultipleTestCase(TestBase):
self.build()
self.tsan_tests()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def tsan_tests(self):
exe = self.getBuildArtifact("a.out")
self.expect(

View File

@ -24,10 +24,6 @@ class TsanThreadNumbersTestCase(TestBase):
self.build()
self.tsan_tests()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def tsan_tests(self):
exe = self.getBuildArtifact("a.out")
self.expect(

View File

@ -22,10 +22,6 @@ class TestVarPath(TestBase):
self.build()
self.do_test()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def verify_point(self, frame, var_name, var_typename, x_value, y_value):
v = frame.GetValueForVariablePath(var_name)
self.assertTrue(v.GetError().Success(), "Make sure we find '%s'" % (var_name))

View File

@ -23,10 +23,6 @@ class TestFindTypesOnStructType(TestBase):
self.build()
self.do_test()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def do_test(self):
"""Make sure FindTypes actually finds 'struct typename' not just 'typename'."""
exe = self.getBuildArtifact("a.out")

View File

@ -26,10 +26,6 @@ class TestUseClosestType(TestBase):
self.main_source_file = lldb.SBFileSpec("main.c")
self.expr_test()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def run_and_check_expr(self, num_children, child_type):
frame = self.thread.GetFrameAtIndex(0)
result = frame.EvaluateExpression("struct Foo *$mine = (struct Foo *) malloc(sizeof(struct Foo)); $mine")

View File

@ -25,10 +25,6 @@ class DynamicValueSameBaseTestCase(TestBase):
self.main_source_file = lldb.SBFileSpec("main.cpp")
self.sample_test()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def sample_test(self):
(target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(self,
"Break here to get started", self.main_source_file)

View File

@ -37,10 +37,6 @@ class TestTrivialABI(TestBase):
self.main_source_file = lldb.SBFileSpec("main.cpp")
self.expr_test(False)
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def check_value(self, test_var, ivar_value):
self.assertTrue(test_var.GetError().Success(), "Invalid valobj: %s"%(test_var.GetError().GetCString()))
ivar = test_var.GetChildMemberWithName("ivar")

View File

@ -12,9 +12,6 @@ from lldbsuite.test import lldbutil
class TestClangModuleAppUpdate(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
TestBase.setUp(self)
@skipUnlessDarwin
@skipIf(debug_info=no_match(["gmodules"]))
def test_rebuild_app_modules_untouched(self):

View File

@ -16,9 +16,6 @@ class ObjCModulesTestCase(TestBase):
NO_DEBUG_INFO_TESTCASE = True
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
TestBase.setUp(self)
@skipUnlessDarwin
def test_expr(self):
self.build()

View File

@ -12,9 +12,6 @@ from lldbsuite.test import lldbutil
class TestClangModuleHashMismatch(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
TestBase.setUp(self)
@skipUnlessDarwin
@skipIf(debug_info=no_match(["gmodules"]))
def test_expr(self):

View File

@ -15,10 +15,6 @@ class ModulesInlineFunctionsTestCase(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
@skipUnlessDarwin
@skipIf(macos_version=["<", "10.12"], debug_info=no_match(["gmodules"]))
def test_expr(self):

View File

@ -12,9 +12,6 @@ from lldbsuite.test import lldbutil
class TestClangModuleUpdate(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
TestBase.setUp(self)
@skipUnlessDarwin
@skipIf(debug_info=no_match(["gmodules"]))
def test_expr(self):

View File

@ -7,9 +7,6 @@ class TestObjCXXBridgedPO(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
TestBase.setUp(self)
@skipUnlessDarwin
def test_bridged_type_po(self):
self.build()

View File

@ -9,9 +9,6 @@ class TestObjCXXHideRuntimeSupportValues(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
TestBase.setUp(self)
@skipIfFreeBSD
@skipIfLinux
@skipIfWindows

View File

@ -8,9 +8,6 @@ from lldbsuite.test import lldbutil
class TestMixedDwarfBinary(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
TestBase.setUp(self)
@no_debug_info_test # Prevent the genaration of the dwarf version of this test
@add_test_categories(["dwo"])
@skipUnlessPlatform(["linux"])

View File

@ -23,10 +23,6 @@ class FindAppInMacOSAppBundle(TestBase):
self.main_source_file = lldb.SBFileSpec("main.c")
self.find_app_in_bundle_test()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def find_app_in_bundle_test(self):
"""This reads in the .app, makes sure we get the right binary and can run it."""

View File

@ -12,10 +12,6 @@ class TestInterruptThreadNames(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
@skipUnlessDarwin
@add_test_categories(['pyapi'])
def test_with_python_api(self):

View File

@ -24,10 +24,6 @@ class TestGetVersionForZero(TestBase):
self.yaml2obj("libDylib.dylib.yaml", self.getBuildArtifact("libDylib.dylib"))
self.do_test()
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def do_test(self):
lib_name = "libDylib.dylib"
target = lldbutil.run_to_breakpoint_make_target(self, exe_name=lib_name)

View File

@ -14,10 +14,6 @@ class ProcessIOTestCase(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
def setup_test(self):
# Get the full path to our executable to be debugged.
self.exe = self.getBuildArtifact("process_io")

View File

@ -18,9 +18,6 @@ class TestStructuredDataAPI(TestBase):
def test(self):
self.structured_data_api_test()
def setUp(self):
TestBase.setUp(self)
@add_test_categories(['pyapi'])
def structured_data_api_test(self):
error = lldb.SBError()

View File

@ -12,10 +12,6 @@ class ValueVarUpdateTestCase(TestBase):
mydir = TestBase.compute_mydir(__file__)
def setUp(self):
# Call super's setUp().
TestBase.setUp(self)
@add_test_categories(['pyapi'])
def test_with_process_launch_api(self):
"""Test SBValue::GetValueDidChange"""