[MLIR] Fix typo and expand gpu.host_register description.

See comments in https://reviews.llvm.org/D85631.

Reviewed By: herhut

Differential Revision: https://reviews.llvm.org/D86214
This commit is contained in:
Christian Sigg 2020-08-19 15:50:44 +02:00
parent 41a8bbad5e
commit 9ba3b7449d
2 changed files with 9 additions and 3 deletions

View File

@ -746,8 +746,14 @@ def GPU_HostRegisterOp : GPU_Op<"host_register">,
Arguments<(ins AnyUnrankedMemRef:$value)> {
let summary = "Registers a memref for access from device.";
let description = [{
This op registers the host memory pointed to by a memref to be accessed from
a device.
This op maps the provided host buffer into the device address space.
This operation may not be supported in every environment, there is not yet a
way to check at runtime whether this feature is supported.
Writes from the host are guaranteed to be visible to device kernels that are
launched afterwards. Writes from the device are guaranteed to be visible on
the host after synchronizing with the device kernel completion.
}];
let assemblyFormat = "$value attr-dict `:` type($value)";

View File

@ -125,7 +125,7 @@ protected:
llvmIntPtrType /* intptr_t elementSizeBytes */}};
};
/// A rewrite patter to convert gpu.host_register operations into a GPU runtime
/// A rewrite pattern to convert gpu.host_register operations into a GPU runtime
/// call. Currently it supports CUDA and ROCm (HIP).
class ConvertHostRegisterOpToGpuRuntimeCallPattern
: public ConvertOpToGpuRuntimeCallPattern<gpu::HostRegisterOp> {