maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[lldb] Correct wording of EXP_MSG 

EXP_MSG generates a message to show on assert
failure. Currently it looks like:
AssertionError: False is not True : '<cmd>'
returns expected result, got '<actual output>'

Which seems to say that the test failed but
also got the expected result.

It should say:
AssertionError: False is not True : '<cmd>'
returned unexpected result, got '<actual output>'

Reviewed By: teemperor, #lldb

Differential Revision: https://reviews.llvm.org/D86603
This commit is contained in:
David Spickett 2020-08-25 16:50:03 +01:00
parent cda6b09242
commit 9ad5d37fd9
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lldb/packages/Python/lldbsuite/test/lldbtest.py
View File

@ -190,11 +190,11 @@ def COMPLETION_MSG(str_before, str_after, completions):
def EXP_MSG(str, actual, exe):
'''A generic "'%s' returns expected result" message generator if exe.
Otherwise, it generates "'%s' matches expected result" message.'''
'''A generic "'%s' returned unexpected result" message generator if exe.
Otherwise, it generates "'%s' does not match expected result" message.'''
return "'%s' %s expected result, got '%s'" % (
str, 'returns' if exe else 'matches', actual.strip())
return "'%s' %s result, got '%s'" % (
str, 'returned unexpected' if exe else 'does not match expected', actual.strip())
def SETTING_MSG(setting):