maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

NFC: Remove NoSideEffect traits from all ops except for ConstantOp. 

These traits are added in chapter 3 when we begin discussion optimization on the toy operations.

PiperOrigin-RevId: 274974010
This commit is contained in:
River Riddle 2019-10-16 00:35:07 -07:00 committed by A. Unique TensorFlower
parent a08482c1ad
commit 98f64b4da1
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mlir/examples/toy/Ch2/include/toy/Ops.td
View File

@ -92,7 +92,7 @@ def ConstantOp : Toy_Op<"constant", [NoSideEffect]> {
let verifier = [{ return ::verify(*this); }]; let verifier = [{ return ::verify(*this); }];
} }
def AddOp : Toy_Op<"add", [NoSideEffect]> { def AddOp : Toy_Op<"add"> {
let summary = "element-wise addition operation"; let summary = "element-wise addition operation";
let description = [{ let description = [{
The "add" operation performs element-wise addition between two tensors. The "add" operation performs element-wise addition between two tensors.
@ -144,7 +144,7 @@ def GenericCallOp : Toy_Op<"generic_call"> {
]; ];
} }
def MulOp : Toy_Op<"mul", [NoSideEffect]> { def MulOp : Toy_Op<"mul"> {
let summary = "element-wise multiplication operation"; let summary = "element-wise multiplication operation";
let description = [{ let description = [{
The "mul" operation performs element-wise multiplication between two The "mul" operation performs element-wise multiplication between two
@ -173,7 +173,7 @@ def PrintOp : Toy_Op<"print"> {
let arguments = (ins F64Tensor:$input); let arguments = (ins F64Tensor:$input);
} }
def ReshapeOp : Toy_Op<"reshape", [NoSideEffect]> { def ReshapeOp : Toy_Op<"reshape"> {
let summary = "tensor reshape operation"; let summary = "tensor reshape operation";
let description = [{ let description = [{
Reshape operation is transforming its input tensor into a new tensor with Reshape operation is transforming its input tensor into a new tensor with
@ -224,7 +224,7 @@ def ReturnOp : Toy_Op<"return", [Terminator, HasParent<"FuncOp">]> {
let verifier = [{ return ::verify(*this); }]; let verifier = [{ return ::verify(*this); }];
} }
def TransposeOp : Toy_Op<"transpose", [NoSideEffect]> { def TransposeOp : Toy_Op<"transpose"> {
let summary = "transpose operation"; let summary = "transpose operation";
let arguments = (ins F64Tensor:$input); let arguments = (ins F64Tensor:$input);