maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[IRBuilder] Avoid passing IRBuilder by value; NFC 

I've fixed most of these before, but missed some occurrences
in targets I don't usually build.
This commit is contained in:
Nikita Popov 2020-02-17 17:15:06 +01:00
parent 8550859535
commit 98ed613ccc
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
View File

@ -647,7 +647,7 @@ bool AMDGPUCodeGenPrepare::foldBinOpIntoSelect(BinaryOperator &BO) const {
// //
// a/b -> a*rcp(b) when inaccurate rcp is allowed with unsafe-fp-math or afn. // a/b -> a*rcp(b) when inaccurate rcp is allowed with unsafe-fp-math or afn.
static Value *optimizeWithRcp(Value *Num, Value *Den, bool AllowInaccurateRcp, static Value *optimizeWithRcp(Value *Num, Value *Den, bool AllowInaccurateRcp,
bool RcpIsAccurate, IRBuilder<> Builder, bool RcpIsAccurate, IRBuilder<> &Builder,
Module *Mod) { Module *Mod) {
if (!AllowInaccurateRcp && !RcpIsAccurate) if (!AllowInaccurateRcp && !RcpIsAccurate)
@ -706,7 +706,7 @@ static Value *optimizeWithRcp(Value *Num, Value *Den, bool AllowInaccurateRcp,
// //
// NOTE: optimizeWithRcp should be tried first because rcp is the preference. // NOTE: optimizeWithRcp should be tried first because rcp is the preference.
static Value *optimizeWithFDivFast(Value *Num, Value *Den, float ReqdAccuracy, static Value *optimizeWithFDivFast(Value *Num, Value *Den, float ReqdAccuracy,
bool HasDenormals, IRBuilder<> Builder, bool HasDenormals, IRBuilder<> &Builder,
Module *Mod) { Module *Mod) {
// fdiv.fast can achieve 2.5 ULP accuracy. // fdiv.fast can achieve 2.5 ULP accuracy.
if (ReqdAccuracy < 2.5f) if (ReqdAccuracy < 2.5f)

20
llvm/lib/Target/ARM/MVEGatherScatterLowering.cpp
View File

@ -79,25 +79,25 @@ private:
// Check for a getelementptr and deduce base and offsets from it, on success // Check for a getelementptr and deduce base and offsets from it, on success
// returning the base directly and the offsets indirectly using the Offsets // returning the base directly and the offsets indirectly using the Offsets
// argument // argument
Value *checkGEP(Value *&Offsets, Type *Ty, Value *Ptr, IRBuilder<> Builder); Value *checkGEP(Value *&Offsets, Type *Ty, Value *Ptr, IRBuilder<> &Builder);
// Compute the scale of this gather/scatter instruction // Compute the scale of this gather/scatter instruction
int computeScale(unsigned GEPElemSize, unsigned MemoryElemSize); int computeScale(unsigned GEPElemSize, unsigned MemoryElemSize);
bool lowerGather(IntrinsicInst *I); bool lowerGather(IntrinsicInst *I);
// Create a gather from a base + vector of offsets // Create a gather from a base + vector of offsets
Value *tryCreateMaskedGatherOffset(IntrinsicInst *I, Value *Ptr, Value *tryCreateMaskedGatherOffset(IntrinsicInst *I, Value *Ptr,
Instruction *&Root, IRBuilder<> Builder); Instruction *&Root, IRBuilder<> &Builder);
// Create a gather from a vector of pointers // Create a gather from a vector of pointers
Value *tryCreateMaskedGatherBase(IntrinsicInst *I, Value *Ptr, Value *tryCreateMaskedGatherBase(IntrinsicInst *I, Value *Ptr,
IRBuilder<> Builder); IRBuilder<> &Builder);
bool lowerScatter(IntrinsicInst *I); bool lowerScatter(IntrinsicInst *I);
// Create a scatter to a base + vector of offsets // Create a scatter to a base + vector of offsets
Value *tryCreateMaskedScatterOffset(IntrinsicInst *I, Value *Ptr, Value *tryCreateMaskedScatterOffset(IntrinsicInst *I, Value *Ptr,
IRBuilder<> Builder); IRBuilder<> &Builder);
// Create a scatter to a vector of pointers // Create a scatter to a vector of pointers
Value *tryCreateMaskedScatterBase(IntrinsicInst *I, Value *Ptr, Value *tryCreateMaskedScatterBase(IntrinsicInst *I, Value *Ptr,
IRBuilder<> Builder); IRBuilder<> &Builder);
}; };
} // end anonymous namespace } // end anonymous namespace
@ -126,7 +126,7 @@ bool MVEGatherScatterLowering::isLegalTypeAndAlignment(unsigned NumElements,
} }
Value *MVEGatherScatterLowering::checkGEP(Value *&Offsets, Type *Ty, Value *Ptr, Value *MVEGatherScatterLowering::checkGEP(Value *&Offsets, Type *Ty, Value *Ptr,
IRBuilder<> Builder) { IRBuilder<> &Builder) {
GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(Ptr); GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(Ptr);
if (!GEP) { if (!GEP) {
LLVM_DEBUG( LLVM_DEBUG(
@ -243,7 +243,7 @@ bool MVEGatherScatterLowering::lowerGather(IntrinsicInst *I) {
} }
Value *MVEGatherScatterLowering::tryCreateMaskedGatherBase( Value *MVEGatherScatterLowering::tryCreateMaskedGatherBase(
IntrinsicInst *I, Value *Ptr, IRBuilder<> Builder) { IntrinsicInst *I, Value *Ptr, IRBuilder<> &Builder) {
using namespace PatternMatch; using namespace PatternMatch;
Type *Ty = I->getType(); Type *Ty = I->getType();
LLVM_DEBUG(dbgs() << "masked gathers: loading from vector of pointers\n"); LLVM_DEBUG(dbgs() << "masked gathers: loading from vector of pointers\n");
@ -263,7 +263,7 @@ Value *MVEGatherScatterLowering::tryCreateMaskedGatherBase(
} }
Value *MVEGatherScatterLowering::tryCreateMaskedGatherOffset( Value *MVEGatherScatterLowering::tryCreateMaskedGatherOffset(
IntrinsicInst *I, Value *Ptr, Instruction *&Root, IRBuilder<> Builder) { IntrinsicInst *I, Value *Ptr, Instruction *&Root, IRBuilder<> &Builder) {
using namespace PatternMatch; using namespace PatternMatch;
Type *OriginalTy = I->getType(); Type *OriginalTy = I->getType();
@ -360,7 +360,7 @@ bool MVEGatherScatterLowering::lowerScatter(IntrinsicInst *I) {
} }
Value *MVEGatherScatterLowering::tryCreateMaskedScatterBase( Value *MVEGatherScatterLowering::tryCreateMaskedScatterBase(
IntrinsicInst *I, Value *Ptr, IRBuilder<> Builder) { IntrinsicInst *I, Value *Ptr, IRBuilder<> &Builder) {
using namespace PatternMatch; using namespace PatternMatch;
Value *Input = I->getArgOperand(0); Value *Input = I->getArgOperand(0);
Value *Mask = I->getArgOperand(3); Value *Mask = I->getArgOperand(3);
@ -384,7 +384,7 @@ Value *MVEGatherScatterLowering::tryCreateMaskedScatterBase(
} }
Value *MVEGatherScatterLowering::tryCreateMaskedScatterOffset( Value *MVEGatherScatterLowering::tryCreateMaskedScatterOffset(
IntrinsicInst *I, Value *Ptr, IRBuilder<> Builder) { IntrinsicInst *I, Value *Ptr, IRBuilder<> &Builder) {
using namespace PatternMatch; using namespace PatternMatch;
Value *Input = I->getArgOperand(0); Value *Input = I->getArgOperand(0);
Value *Mask = I->getArgOperand(3); Value *Mask = I->getArgOperand(3);