maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[GISel][CombinerHelper] Use uses() instead of operands() when traversing use operands. 

NFC
This commit is contained in:
Quentin Colombet 2019-11-15 13:33:35 -08:00
parent 304abde077
commit 98ceac4981
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
View File

@ -109,10 +109,7 @@ bool CombinerHelper::matchCombineConcatVectors(MachineInstr &MI, bool &IsUndef,
// Walk over all the operands of concat vectors and check if they are // Walk over all the operands of concat vectors and check if they are
// build_vector themselves or undef. // build_vector themselves or undef.
// Then collect their operands in Ops. // Then collect their operands in Ops.
for (const MachineOperand &MO : MI.operands()) { for (const MachineOperand &MO : MI.uses()) {
// Skip the instruction definition.
if (MO.isDef())
continue;
Register Reg = MO.getReg(); Register Reg = MO.getReg();
MachineInstr *Def = MRI.getVRegDef(Reg); MachineInstr *Def = MRI.getVRegDef(Reg);
assert(Def && "Operand not defined"); assert(Def && "Operand not defined");
@ -121,12 +118,8 @@ bool CombinerHelper::matchCombineConcatVectors(MachineInstr &MI, bool &IsUndef,
IsUndef = false; IsUndef = false;
// Remember the operands of the build_vector to fold // Remember the operands of the build_vector to fold
// them into the yet-to-build flattened concat vectors. // them into the yet-to-build flattened concat vectors.
for (const MachineOperand &BuildVecMO : Def->operands()) { for (const MachineOperand &BuildVecMO : Def->uses())
// Skip the definition.
if (BuildVecMO.isDef())
continue;
Ops.push_back(BuildVecMO.getReg()); Ops.push_back(BuildVecMO.getReg());
}
break; break;
case TargetOpcode::G_IMPLICIT_DEF: { case TargetOpcode::G_IMPLICIT_DEF: {
LLT OpType = MRI.getType(Reg); LLT OpType = MRI.getType(Reg);