From 98ceac498167cfadb05c5bd7590525d75bda01c4 Mon Sep 17 00:00:00 2001 From: Quentin Colombet Date: Fri, 15 Nov 2019 13:33:35 -0800 Subject: [PATCH] [GISel][CombinerHelper] Use uses() instead of operands() when traversing use operands. NFC --- llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp b/llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp index 504f0eb76003..bcf31e16142c 100644 --- a/llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp +++ b/llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp @@ -109,10 +109,7 @@ bool CombinerHelper::matchCombineConcatVectors(MachineInstr &MI, bool &IsUndef, // Walk over all the operands of concat vectors and check if they are // build_vector themselves or undef. // Then collect their operands in Ops. - for (const MachineOperand &MO : MI.operands()) { - // Skip the instruction definition. - if (MO.isDef()) - continue; + for (const MachineOperand &MO : MI.uses()) { Register Reg = MO.getReg(); MachineInstr *Def = MRI.getVRegDef(Reg); assert(Def && "Operand not defined"); @@ -121,12 +118,8 @@ bool CombinerHelper::matchCombineConcatVectors(MachineInstr &MI, bool &IsUndef, IsUndef = false; // Remember the operands of the build_vector to fold // them into the yet-to-build flattened concat vectors. - for (const MachineOperand &BuildVecMO : Def->operands()) { - // Skip the definition. - if (BuildVecMO.isDef()) - continue; + for (const MachineOperand &BuildVecMO : Def->uses()) Ops.push_back(BuildVecMO.getReg()); - } break; case TargetOpcode::G_IMPLICIT_DEF: { LLT OpType = MRI.getType(Reg);