maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix a couple of tests that assumed that compare retunred -1/0/1 instead of <0/0/>0. Thanks to Jonathan Wakely for the report. 

llvm-svn: 359104
This commit is contained in:
Marshall Clow 2019-04-24 15:14:14 +00:00
parent f7f00ebc27
commit 98b15320e4
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libcxx/test/std/strings/string.view/string.view.ops/compare.pointer.pass.cpp
View File

@ -118,8 +118,8 @@ int main(int, char**)
constexpr SV sv1;
constexpr SV sv2 { "abcde", 5 };
static_assert ( sv1.compare("") == 0, "" );
static_assert ( sv1.compare("abcde") == -1, "" );
static_assert ( sv2.compare("") == 1, "" );
static_assert ( sv1.compare("abcde") < 0, "" );
static_assert ( sv2.compare("") > 0, "" );
static_assert ( sv2.compare("abcde") == 0, "" );
}
#endif

4
libcxx/test/std/strings/string.view/string.view.ops/compare.pointer_size.pass.cpp
View File

@ -444,8 +444,8 @@ int main(int, char**)
constexpr SV sv1;
constexpr SV sv2 { "abcde", 5 };
static_assert ( sv1.compare(0, 0, "") == 0, "" );
static_assert ( sv1.compare(0, 0, "abcde") == -1, "" );
static_assert ( sv2.compare(0, 2, "") == 1, "" );
static_assert ( sv1.compare(0, 0, "abcde") < 0, "" );
static_assert ( sv2.compare(0, 2, "") > 0, "" );
static_assert ( sv2.compare(0, 6, "abcde") == 0, "" );
}
#endif

2
libcxx/test/std/strings/string.view/string.view.ops/compare.size_size_sv_pointer_size.pass.cpp
View File

@ -1345,7 +1345,7 @@ int main(int, char**) {
constexpr SV sv1;
constexpr SV sv2 { "abcdefghijklmnopqrst", 21 };
static_assert ( sv1.compare(0, 0, "abcde", 0) == 0, "" );
static_assert ( sv1.compare(0, 0, "abcde", 1) == -1, "" );
static_assert ( sv1.compare(0, 0, "abcde", 1) < 0, "" );
static_assert ( sv2.compare(0, 0, "abcde", 1, 0) == 0, "" );
}
#endif

4
libcxx/test/std/strings/string.view/string.view.ops/compare.size_size_sv_size_size.pass.cpp
View File

@ -5840,8 +5840,8 @@ int main(int, char**) {
typedef std::basic_string_view<char, constexpr_char_traits<char>> SV;
constexpr SV sv1 { "abcde", 5 };
static_assert ( sv1.compare(5, 1, "", 0, 0) == 0, "" );
static_assert ( sv1.compare(2, 4, "", 0, 0) == 1, "" );
static_assert ( sv1.compare(2, 4, "abcde", 3, 4) == -1, "" );
static_assert ( sv1.compare(2, 4, "", 0, 0) > 0, "" );
static_assert ( sv1.compare(2, 4, "abcde", 3, 4) < 0, "" );
}
#endif