From 98952851911624918c9bb7309dd8030a73f8ef76 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Wed, 7 Apr 2021 12:17:42 -0700 Subject: [PATCH] [RISCV] Replace 'return ReplaceNode' with 'ReplaceNode; return;' NFC ReplaceNode is a void function as is the function that we were doing this in. While this is valid code, it was a bit confusing. --- llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp b/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp index 57de6ceeef40..e20a7c3c6777 100644 --- a/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp +++ b/llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp @@ -411,7 +411,6 @@ void RISCVDAGToDAGISel::Select(SDNode *Node) { } ReplaceNode(Node, selectImm(CurDAG, DL, ConstNode->getSExtValue(), XLenVT)); return; - break; } case ISD::FrameIndex: { SDValue Imm = CurDAG->getTargetConstant(0, DL, XLenVT); @@ -925,11 +924,13 @@ void RISCVDAGToDAGISel::Select(SDNode *Node) { SDValue RC = CurDAG->getTargetConstant(InRegClassID, DL, XLenVT); SDNode *NewNode = CurDAG->getMachineNode(TargetOpcode::COPY_TO_REGCLASS, DL, VT, SubV, RC); - return ReplaceNode(Node, NewNode); + ReplaceNode(Node, NewNode); + return; } SDValue Insert = CurDAG->getTargetInsertSubreg(SubRegIdx, DL, VT, V, SubV); - return ReplaceNode(Node, Insert.getNode()); + ReplaceNode(Node, Insert.getNode()); + return; } case ISD::EXTRACT_SUBVECTOR: { SDValue V = Node->getOperand(0); @@ -968,11 +969,13 @@ void RISCVDAGToDAGISel::Select(SDNode *Node) { SDValue RC = CurDAG->getTargetConstant(InRegClassID, DL, XLenVT); SDNode *NewNode = CurDAG->getMachineNode(TargetOpcode::COPY_TO_REGCLASS, DL, VT, V, RC); - return ReplaceNode(Node, NewNode); + ReplaceNode(Node, NewNode); + return; } SDValue Extract = CurDAG->getTargetExtractSubreg(SubRegIdx, DL, VT, V); - return ReplaceNode(Node, Extract.getNode()); + ReplaceNode(Node, Extract.getNode()); + return; } }