maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[mips][FastISel] Fix call lowering by bailing out on "fastcc" calls. 

Summary:
Currently, we support only the MIPS O32 ABI calling convention for call
lowering. With this change we avoid using the O32 calling convetion for
lowering calls marked as using the fast calling convention.

Reviewers: dsanders

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D11515

llvm-svn: 243485
This commit is contained in:
Vasileios Kalintiris 2015-07-28 21:43:31 +00:00
parent c69780d797
commit 9876946aee
2 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
llvm/lib/Target/Mips/MipsFastISel.cpp
View File

@ -1245,6 +1245,10 @@ bool MipsFastISel::fastLowerCall(CallLoweringInfo &CLI) {
const Value *Callee = CLI.Callee; const Value *Callee = CLI.Callee;
MCSymbol *Symbol = CLI.Symbol; MCSymbol *Symbol = CLI.Symbol;
// Do not handle FastCC.
if (CC == CallingConv::Fast)
return false;
// Allow SelectionDAG isel to handle tail calls. // Allow SelectionDAG isel to handle tail calls.
if (IsTailCall) if (IsTailCall)
return false; return false;
@ -1422,6 +1426,11 @@ bool MipsFastISel::selectRet(const Instruction *I) {
if (Ret->getNumOperands() > 0) { if (Ret->getNumOperands() > 0) {
CallingConv::ID CC = F.getCallingConv(); CallingConv::ID CC = F.getCallingConv();
// Do not handle FastCC.
if (CC == CallingConv::Fast)
return false;
SmallVector<ISD::OutputArg, 4> Outs; SmallVector<ISD::OutputArg, 4> Outs;
GetReturnInfo(F.getReturnType(), F.getAttributes(), Outs, TLI, DL); GetReturnInfo(F.getReturnType(), F.getAttributes(), Outs, TLI, DL);

16
llvm/test/CodeGen/Mips/Fast-ISel/fastcc-miss.ll Normal file
View File

@ -0,0 +1,16 @@
; RUN: llc < %s -march=mipsel -mcpu=mips32r2 -O0 -relocation-model=pic \
; RUN: -fast-isel=true -mips-fast-isel -fast-isel-verbose 2>&1 | \
; RUN: FileCheck %s
; CHECK: FastISel missed call:
; CHECK-SAME: %call = call fastcc i32 @foo(i32 signext %a, i32 signext %b)
define internal i32 @bar(i32 signext %a, i32 signext %b) {
%s = and i32 %a, %b
ret i32 %s
}
define i32 @foo(i32 signext %a, i32 signext %b) {
%call = call fastcc i32 @foo(i32 signext %a, i32 signext %b)
ret i32 %call
}