maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[BOLT] Add BinaryContext::IsStripped 

Determine stripped status of a binary based on .symtab

Test Plan:
```
ninja check-bolt
```

Reviewed By: Amir

Differential Revision: https://reviews.llvm.org/D130034
This commit is contained in:
Huan Nguyen 2022-07-28 23:08:45 -07:00 committed by Amir Ayupov
parent dc2557fe2b
commit 986362d4a3
3 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bolt/include/bolt/Core/BinaryContext.h
View File

@ -585,6 +585,9 @@ public:
/// Indicates if relocations are available for usage.
bool HasRelocations{false};
/// Indicates if the binary is stripped
bool IsStripped{false};
/// Is the binary always loaded at a fixed address. Shared objects and
/// position-independent executables (PIEs) are examples of binaries that
/// will have HasFixedLoadAddress set to false.

8
bolt/lib/Rewrite/RewriteInstance.cpp
View File

@ -1562,6 +1562,7 @@ Error RewriteInstance::readSpecialSections() {
TimerGroupName, TimerGroupDesc, opts::TimeRewrite);
bool HasTextRelocations = false;
bool HasSymbolTable = false;
bool HasDebugInfo = false;
// Process special sections.
@ -1593,6 +1594,7 @@ Error RewriteInstance::readSpecialSections() {
}
HasTextRelocations = (bool)BC->getUniqueSectionByName(".rela.text");
HasSymbolTable = (bool)BC->getUniqueSectionByName(".symtab");
LSDASection = BC->getUniqueSectionByName(".gcc_except_table");
EHFrameSection = BC->getUniqueSectionByName(".eh_frame");
GOTPLTSection = BC->getUniqueSectionByName(".got.plt");
@ -1629,6 +1631,8 @@ Error RewriteInstance::readSpecialSections() {
BC->HasRelocations =
HasTextRelocations && (opts::RelocationMode != cl::BOU_FALSE);
BC->IsStripped = !HasSymbolTable;
// Force non-relocation mode for heatmap generation
if (opts::HeatmapMode)
BC->HasRelocations = false;
@ -1637,6 +1641,10 @@ Error RewriteInstance::readSpecialSections() {
outs() << "BOLT-INFO: enabling " << (opts::StrictMode ? "strict " : "")
<< "relocation mode\n";
if (BC->IsStripped)
outs() << "BOLT-INFO: input binary is stripped. The support is limited and "
<< "is considered experimental.\n";
// Read EH frame for function boundaries info.
Expected<const DWARFDebugFrame *> EHFrameOrError = BC->DwCtx->getEHFrame();
if (!EHFrameOrError)

10
bolt/test/X86/is-strip.s Normal file
View File

@ -0,0 +1,10 @@
# This test checks whether a binary is stripped or not.
# RUN: %clang++ %p/Inputs/linenumber.cpp -o %t -Wl,-q
# RUN: llvm-bolt %t -o %t.out 2>&1 | FileCheck %s -check-prefix=CHECK-NOSTRIP
# RUN: cp %t %t.stripped
# RUN: llvm-strip -s %t.stripped
# RUN: llvm-bolt %t.stripped -o %t.out 2>&1 | FileCheck %s -check-prefix=CHECK-STRIP
# CHECK-NOSTRIP-NOT: BOLT-INFO: input binary is stripped. The support is limited and is considered experimental.
# CHECK-STRIP: BOLT-INFO: input binary is stripped. The support is limited and is considered experimental.