maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[IR/Verifier] Don't visit DISubprograms more than needed. 

Before this patch we happened to visit twice, one when scanning
MDNodes and the other one while visiting the function. Remove
the explicit call to visitDISubprogram there, so we don't emit
the same error twice in case the verifier fail and we save some
time when running it.
Thanks to Justin Bogner for the report and Adrian for the quick
review!

PR: 31995
llvm-svn: 295537
This commit is contained in:
Davide Italiano 2017-02-18 03:02:44 +00:00
parent bd4cd0c063
commit 982bf827b5
2 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/lib/IR/Verifier.cpp
View File

@ -2119,8 +2119,6 @@ void Verifier::visitFunction(const Function &F) {
if (!N)
return;
visitDISubprogram(*N);
// Check that all !dbg attachments lead to back to N (or, at least, another
// subprogram that describes the same function).
//

17
llvm/test/DebugInfo/Generic/invalid.ll Normal file
View File

@ -0,0 +1,17 @@
; RUN: not opt -verify %s 2>&1 | FileCheck %s
; Make sure we emit this diagnostic only once (which means we don't visit the
; same DISubprogram twice.
; CHECK: subprogram definitions must have a compile unit
; CHECK-NEXT: !3 = distinct !DISubprogram(name: "patatino", scope: null, isLocal: false, isDefinition: true, isOptimized: false)
; CHECK-NOT: subprogram definitions must have a compile unit
; CHECK-NOT: !3 = distinct !DISubprogram(name: "patatino", scope: null, isLocal: false, isDefinition: true, isOptimized: false)
define void @tinkywinky() !dbg !3 { ret void }
!llvm.module.flags = !{!4}
!llvm.dbg.cu = !{!0}
!0 = distinct !DICompileUnit(language: 12, file: !1)
!1 = !DIFile(filename: "/home/davide", directory: "/home/davide")
!3 = distinct !DISubprogram(name: "patatino", isDefinition: true)
!4 = !{i32 2, !"Debug Info Version", i32 3}