maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Don't mix overload and default values. 

It makes it hard to see which one is being called.

llvm-svn: 234100
This commit is contained in:
Rafael Espindola 2015-04-04 18:16:01 +00:00
parent 8ca44f0b5c
commit 972d55851a
2 changed files with 26 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
llvm/include/llvm/MC/MCContext.h
View File

@ -297,19 +297,42 @@ namespace llvm {
BeginSymName); BeginSymName);
} }
const MCSectionELF *getELFSection(StringRef Section, unsigned Type,
unsigned Flags) {
return getELFSection(Section, Type, Flags, nullptr);
}
const MCSectionELF *getELFSection(StringRef Section, unsigned Type, const MCSectionELF *getELFSection(StringRef Section, unsigned Type,
unsigned Flags, unsigned Flags,
const char *BeginSymName = nullptr); const char *BeginSymName) {
return getELFSection(Section, Type, Flags, 0, "", BeginSymName);
}
const MCSectionELF *getELFSection(StringRef Section, unsigned Type,
unsigned Flags, unsigned EntrySize,
StringRef Group) {
return getELFSection(Section, Type, Flags, EntrySize, Group, nullptr);
}
const MCSectionELF *getELFSection(StringRef Section, unsigned Type, const MCSectionELF *getELFSection(StringRef Section, unsigned Type,
unsigned Flags, unsigned EntrySize, unsigned Flags, unsigned EntrySize,
StringRef Group, StringRef Group,
const char *BeginSymName = nullptr); const char *BeginSymName) {
return getELFSection(Section, Type, Flags, EntrySize, Group, ~0,
BeginSymName);
}
const MCSectionELF *getELFSection(StringRef Section, unsigned Type,
unsigned Flags, unsigned EntrySize,
StringRef Group, unsigned UniqueID) {
return getELFSection(Section, Type, Flags, EntrySize, Group, UniqueID,
nullptr);
}
const MCSectionELF *getELFSection(StringRef Section, unsigned Type, const MCSectionELF *getELFSection(StringRef Section, unsigned Type,
unsigned Flags, unsigned EntrySize, unsigned Flags, unsigned EntrySize,
StringRef Group, unsigned UniqueID, StringRef Group, unsigned UniqueID,
const char *BeginSymName = nullptr); const char *BeginSymName);
const MCSectionELF *createELFRelSection(StringRef Name, unsigned Type, const MCSectionELF *createELFRelSection(StringRef Name, unsigned Type,
unsigned Flags, unsigned EntrySize, unsigned Flags, unsigned EntrySize,

14
llvm/lib/MC/MCContext.cpp
View File

@ -262,12 +262,6 @@ MCContext::getMachOSection(StringRef Segment, StringRef Section,
Reserved2, Kind, Begin); Reserved2, Kind, Begin);
} }
const MCSectionELF *MCContext::getELFSection(StringRef Section, unsigned Type,
unsigned Flags,
const char *BeginSymName) {
return getELFSection(Section, Type, Flags, 0, "", BeginSymName);
}
void MCContext::renameELFSection(const MCSectionELF *Section, StringRef Name) { void MCContext::renameELFSection(const MCSectionELF *Section, StringRef Name) {
StringRef GroupName; StringRef GroupName;
if (const MCSymbol *Group = Section->getGroup()) if (const MCSymbol *Group = Section->getGroup())
@ -330,14 +324,6 @@ const MCSectionELF *MCContext::getELFSection(StringRef Section, unsigned Type,
return Result; return Result;
} }
const MCSectionELF *MCContext::getELFSection(StringRef Section, unsigned Type,
unsigned Flags, unsigned EntrySize,
StringRef Group,
const char *BeginSymName) {
return getELFSection(Section, Type, Flags, EntrySize, Group, ~0,
BeginSymName);
}
const MCSectionELF *MCContext::CreateELFGroupSection() { const MCSectionELF *MCContext::CreateELFGroupSection() {
MCSectionELF *Result = new (*this) MCSectionELF *Result = new (*this)
MCSectionELF(".group", ELF::SHT_GROUP, 0, SectionKind::getReadOnly(), 4, MCSectionELF(".group", ELF::SHT_GROUP, 0, SectionKind::getReadOnly(), 4,