maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang-tidy] Fix crash in modernize-use-noexcept on uninstantiated throw class 

Bug: https://bugs.llvm.org/show_bug.cgi?id=47446

Differential Revision: https://reviews.llvm.org/D87627
This commit is contained in:
Zinovy Nis 2020-09-14 22:08:00 +03:00
parent 8a04cdb510
commit 96c6d012df
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clang-tools-extra/clang-tidy/modernize/UseNoexceptCheck.cpp
View File

@ -77,13 +77,16 @@ void UseNoexceptCheck::check(const MatchFinder::MatchResult &Result) {
.getExceptionSpecRange();
}
assert(FnTy && "FunctionProtoType is null.");
if (isUnresolvedExceptionSpec(FnTy->getExceptionSpecType()))
return;
assert(Range.isValid() && "Exception Source Range is invalid.");
CharSourceRange CRange = Lexer::makeFileCharRange(
CharSourceRange::getTokenRange(Range), *Result.SourceManager,
Result.Context->getLangOpts());
assert(FnTy && "FunctionProtoType is null.");
bool IsNoThrow = FnTy->isNothrow();
StringRef ReplacementStr =
IsNoThrow

6
clang-tools-extra/test/clang-tidy/checkers/modernize-use-noexcept-opt.cpp
View File

@ -4,6 +4,7 @@
// This test is not run in C++17 or later because dynamic exception
// specifications were removed in C++17.
using size_t = __SIZE_TYPE__;
class A {};
class B {};
@ -19,6 +20,11 @@ void k() throw(int(int));
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: dynamic exception specification 'throw(int(int))' is deprecated; consider removing it instead [modernize-use-noexcept]
// CHECK-FIXES: void k() ;
// Shouldn't crash due to llvm_unreachable in canThrow() on EST_Uninstantiated
template <int> class c { void *operator new(size_t) throw (int);};
void s() { c<1> doesnt_crash; }
// CHECK-MESSAGES: :[[@LINE-2]]:53: warning: dynamic exception specification 'throw (int)' is deprecated; consider removing it instead [modernize-use-noexcept]
void foobar() throw(A, B)
{}
// CHECK-MESSAGES: :[[@LINE-2]]:15: warning: dynamic exception specification 'throw(A, B)' is deprecated; consider removing it instead [modernize-use-noexcept]