From 969c6512c277ffca58d691322db7f61be4006458 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Wed, 31 May 2017 20:22:27 +0000 Subject: [PATCH] Move clearOutputSections earlier. Another step into merging the linker script and non linker script code paths. llvm-svn: 304339 --- lld/ELF/LinkerScript.cpp | 7 ++++++- lld/ELF/Writer.cpp | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/lld/ELF/LinkerScript.cpp b/lld/ELF/LinkerScript.cpp index a5ca4a2e6e88..eecbe9cef18c 100644 --- a/lld/ELF/LinkerScript.cpp +++ b/lld/ELF/LinkerScript.cpp @@ -1085,7 +1085,12 @@ template void OutputSectionCommand::writeTo(uint8_t *Buf) { return; // Write leading padding. - ArrayRef Sections = Sec->Sections; + std::vector Sections; + for (BaseCommand *Cmd : Commands) + if (auto *ISD = dyn_cast(Cmd)) + for (InputSection *IS : ISD->Sections) + if (IS->Live) + Sections.push_back(IS); uint32_t Filler = getFiller(); if (Filler) fill(Buf, Sections.empty() ? Sec->Size : Sections[0]->OutSecOff, Filler); diff --git a/lld/ELF/Writer.cpp b/lld/ELF/Writer.cpp index 55cb8565076a..20f86f0f212d 100644 --- a/lld/ELF/Writer.cpp +++ b/lld/ELF/Writer.cpp @@ -300,13 +300,13 @@ template void Writer::run() { openFile(); if (ErrorCount) return; + clearOutputSections(); if (!Config->OFormatBinary) { writeHeader(); writeSections(); } else { writeSectionsBinary(); } - clearOutputSections(); // Backfill .note.gnu.build-id section content. This is done at last // because the content is usually a hash value of the entire output file.